8000 Adds integration tests for Help and Feedback section. Closes #418 by Saurabh7019 · Pull Request #513 · pnp/vscode-viva · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds integration tests for Help and Feedback section. Closes #418 #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2025
Merged

Adds integration tests for Help and Feedback section. Closes #418 #513

merged 3 commits into from
Jun 16, 2025

Conversation

Saurabh7019
Copy link
Collaborator

🎯 Aim

Adds integration tests for Help and Feedback section.

📷 Result

image

✅ What was done

  • Added a new test suite for 'Help and feedback'
  • Verified pnp-view-help is contributed
  • Moved helpCommands outside of CommandPanel for testability
  • Validated the structure, items, and links

🔗 Related issue

Closes: #418

@Saurabh7019 Saurabh7019 linked an issue Jun 9, 2025 that may be closed by this pull request
💡 [Feature]: Add integration tests for Help and Feedback section #418
Closed
@Adam-it Adam-it self-assigned this Jun 12, 2025
Adam-it
Adam-it previously approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member
@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👏
Checked locally
image

@Adam-it
Copy link
Member
Adam-it commented Jun 12, 2025

@Saurabh7019 I only left few, well actually it all comes down to one, comment we could recheck before we merge. Let me know what do you think and how you would like us to proceed on that.
Other than that the code LGTM and it works a well 🙂

@Adam-it Adam-it marked this pull request as draft June 12, 2025 23:04
@Saurabh7019
Copy link
Collaborator Author

for now, I am keeping the constants file in the test folder. I don't think we will have many shared constants or utilities across the test suites. Should we add a few more test suites and revisit organizing the constants into a separate folder if needed?

@Saurabh7019 Saurabh7019 marked this pull request as ready for review June 13, 2025 15:46
@Adam-it
Copy link
Member
Adam-it commented Jun 14, 2025

for now, I am keeping the constants file in the test folder. I don't think we will have many shared constants or utilities across the test suites. Should we add a few more test suites and revisit organizing the constants into a separate folder if needed?

Awesome. 👏👏👏
will merge this early next week 👍

@Saurabh7019 Saurabh7019 mentioned this pull request Jun 16, 2025
Open
4 tasks
@Adam-it Adam-it changed the title Adds integration tests for Help and Feedback section. Adds integration tests for Help and Feedback section. Closes: #418 Jun 16, 2025
@Adam-it Adam-it changed the title Adds integration tests for Help and Feedback section. Closes: #418 Adds integration tests for Help and Feedback section. Closes #418 Jun 16, 2025
@Adam-it Adam-it merged commit e10bbcd into pnp:dev Jun 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 [Feature]: Add integration tests for Help and Feedback section
2 participants
@Saurabh7019 @Adam-it
0