Refactor/Chore: Remove access parameters in client #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstlaurent
approved these changes
May 14, 2025
There was a problem hiding this comment.
👍 Some of these methods will be removed by @danielpeng1's #289 , but the change to model upload is still needed.
Yeah I'll wait for his PR to be merged, and adjust as needed. Or I could merge this first. |
Andrewq11
approved these changes
May 14, 2025
| response = self._base_request_to_hub( | ||
| url="/v2/result", method="POST", json={"access": access, **result_json} | ||
| ) | ||
| response = self._base_request_to_hub(url="/v2/result", method="POST", json={**result_json}) |
There was a problem hiding this comment.
Suggestion:
Suggested change
| response = self._base_request_to_hub(url="/v2/result", method="POST", json={**result_json}) | |
| response = self._base_request_to_hub(url="/v2/result", method="POST", json=result_json) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
AccessTypetype, simplifying the API by eliminating theaccessparameter, which was previously used to specify public or private access when uploading artifacts to the Polaris Hub.Removal of
AccessTypeandaccessparameter:Type and Imports Cleanup:
AccessTypefrom imports in multiple files, includingpolaris/benchmark/_base.py,polaris/dataset/_base.py,polaris/dataset/_dataset.py,polaris/dataset/_dataset_v2.py,polaris/evaluate/_results.py,polaris/hub/client.py, andpolaris/model/__init__.py.Parameter Removal in Method Definitions:
accessparameter from method signatures such asupload_to_hubin various modules (polaris/benchmark/_base.py, < 8000 code class="notranslate">polaris/dataset/_base.py,polaris/dataset/_dataset.py,polaris/dataset/_dataset_v2.py,polaris/evaluate/_results.py,polaris/hub/client.py, andpolaris/model/__init__.py).Documentation Updates:
accessparameter, ensuring the documentation aligns with the updated API.Notion Package: https://www.notion.so/Private-Artifact-Removal-1ec0c0d8de7080cf9b6fdde6b7fc0dd8