8000 [ISSUE #187] Hot fix cannt return namespace by chuntaojun · Pull Request #211 · polarismesh/polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE #187] Hot fix cannt return namespace #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 29, 2021
Merged

[ISSUE #187] Hot fix cannt return namespace #211

merged 6 commits into from
Dec 29, 2021

Conversation

chuntaojun
Copy link
Member
@chuntaojun chuntaojun commented Dec 29, 2021 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #187

  • 修复命名空间列表无法查询问题
  • 修复命名空间列表分页逻辑错误

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@chuntaojun chuntaojun linked an issue Dec 29, 2021 that may be closed by this pull request
Adding tombstone capability to boltdb causes data deletion to become invalid #187
Closed
@chuntaojun chuntaojun changed the title Hot fix cannt return ns [ISSUE #187] Hot fix cannt return namespace Dec 29, 2021
@chuntaojun
Copy link
Member Author

修改点

  • 调整GetNamespaces时， isFind 的初始值以及判断元素符合预期加入返回列表的位置，修复当filters为空时返回了空命名空间列表
  • 修复命名空间翻页时 startIndex 的问题，不应该是 offset * limit

@chuntaojun chuntaojun added the bug Something isn't working label Dec 29, 2021
@chuntaojun chuntaojun self-assigned this Dec 29, 2021
@chuntaojun chuntaojun added this to the v1.4.0 milestone Dec 29, 2021
andrewshan
andrewshan reviewed Dec 29, 2021
View reviewed changes
@andrewshan andrewshan merged commit 04503b9 into polarismesh:main Dec 29, 2021
@chuntaojun chuntaojun deleted the hot_fix_cannt_return_ns branch October 21, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewshan andrewshan andrewshan left review comments

Assignees

@chuntaojun chuntaojun

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Adding tombstone capability to boltdb causes data deletion to become invalid
2 participants
@chuntaojun @andrewshan
0