ENH: Set loop_preproc during model loading #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
commented
Aug 13, 2018
| @@ -159,6 +159,8 @@ class LoadBIDSModel(SimpleInterface): | |||
| output_spec = LoadBIDSModelOutputSpec | |||
|
|
|||
| def _run_interface(self, runtime): | |||
| import bids | |||
| bids.config.set_options(loop_preproc=True) | |||
There was a problem hiding this comment.
@adelavega Does this look like the right place to do this? My understanding is the time to do it is before bids.Analysis().setup() is called. Are there any other cases where it's important to ensure this is set?
There was a problem hiding this comment.
That seems right to me. The actual function that uses this is load_variables so as long as its done prior to that, it should work.
There was a problem hiding this comment.
Sounds good. I'll go ahead and merge. If you have some time to test, we can see how badly I broke things for you with the workflow update, too.
effigies
added a commit
that referenced
this pull request
Aug 24, 2018
This release moves FitLins to a Nipype workflow and provides a set of Nipype interfaces for interacting with BIDS Models and the nistats statistical package. * FIX: Correctly handle missing confounds (#73) * ENH: Set loop_preproc during model loading (#66) * REF: Second-level workflow (#30) * DOC: Example model (#63) * MAINT: Update nipype, grabbit and pybids dependencies (#70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be app
2F48
lied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple things.
loop_preprocconfig option inLoadBIDSModelinterface, so that datasets missing original BOLD files can still run. This should make it a FitLins a little cheaper in IO terms, especially if working with DataLad datasets, that now do not need togetthe originals.bids.configchanges to be confined to a single interface, but I think that might depend on the nipype plugin whether that's the case.bids.BIDSLayoutandbids.Analysisrather thanbids.grabbids.BIDSLayoutandbids.analysis.Analysis. The former will help avoid thegrabbids/layoutorganizational issue, and the latter is mostly for symmetry.Closes #65.