8000 ENH: Avoid casting BOLD data to float64 if possible by effigies · Pull Request #196 · poldracklab/fitlins · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ENH: Avoid casting BOLD data to float64 if possible #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2019
Merged

ENH: Avoid casting BOLD data to float64 if possible #196

merged 1 commit into from
Nov 11, 2019

Conversation

effigies
Copy link
Collaborator
@effigies effigies commented Nov 9, 2019

This change avoids unnecessary casts of BOLD data to float64, by hacking the niimg.dataobj parameters.

Related: neuroscout/neuroscout#601

@effigies effigies requested a review from adelavega November 9, 2019 17:55
@codecov-io
Copy link
codecov-io commented Nov 9, 2019 •
edited
Loading

Codecov Report

Merging #196 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #196      +/-   ##
=========================================
- Coverage   76.26%   76.2%   -0.06%     
=========================================
  Files          18      18              
  Lines        1011    1017       +6     
  Branches      177     179       +2     
=========================================
+ Hits          771     775       +4     
- Misses        149     150       +1     
- Partials       91      92       +1
Flag Coverage Δ
#ds003 76.2% <66.66%> (-0.06%) ⬇️
Impacted Files Coverage Δ
fitlins/interfaces/nistats.py 80.29% <66.66%> (-0.63%) ⬇️
fitlins/interfaces/bids.py 74.1% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ea905...eead536. Read the comment docs.

adelavega
adelavega reviewed Nov 11, 2019
View reviewed changes
Copy link
Collaborator
@adelavega adelavega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other instances of loading the functionals that we should be worried about? And if so modularize it, and make it optional via CLI?

@effigies
Copy link
Collaborator Author

No.

@effigies effigies merged commit ed0d9d3 into poldracklab:master Nov 11, 2019
@effigies effigies deleted the enh/float32_data branch November 11, 2019 17:39
@adelavega adelavega mentioned this pull request Nov 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelavega adelavega adelavega left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@effigies @codecov-io @adelavega
0