8000 Adding a section on estimators by Shotgunosine · Pull Request #375 · poldracklab/fitlins · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding a section on estimators #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 28, 2022
Merged

Adding a section on estimators #375

merged 8 commits into from
Jul 28, 2022

Conversation

Shotgunosine
Copy link
Collaborator

No description provided.

@pep8speaks
Copy link
pep8speaks commented Jun 16, 2022 •
edited
Loading

Hello @Shotgunosine, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 fitlins.

Comment last updated at 2022-07-22 20:30:26 UTC

@codecov-commenter
Copy link
codecov-commenter commented Jun 16, 2022 •
edited
Loading

Codecov Report

Merging #375 (20045e3) into dev (372e6d2) will decrease coverage by 0.08%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##              dev     #375      +/-   ##
==========================================
- Coverage   64.42%   64.34%   -0.09%     
==========================================
  Files          23       23              
  Lines        1816     1820       +4     
  Branches      343      345       +2     
==========================================
+ Hits         1170     1171       +1     
- Misses        564      566       +2     
- Partials       82       83       +1
Impacted Files Coverage Δ
fitlins/cli/run.py 0.00% <0.00%> (ø)
fitlins/workflows/base.py 58.97% <33.33%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372e6d2...20045e3. Read the comment docs.

@Shotgunosine Shotgunosine changed the title WIP: adding a section on estimators Adding a section on estimators Jun 17, 2022
@Shotgunosine Shotgunosine mentioned this pull request Jul 19, 2022
Merged
adelavega
adelavega requested changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator
@adelavega adelavega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition! Some comments

effigies
effigies reviewed Jul 22, 2022
View reviewed changes
docs/conf.py
@@ -57,6 +57,11 @@

source_suffix = ['.rst', '.md']

intersphinx_mapping = {
'nilearn': ('https://nilearn.github.io/', None),
'afni': ('https://afni.nimh.nih.gov/pub/dist/doc/htmldoc/', None)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. That's really cool.

@effigies
Copy link
Collaborator

@Shotgunosine @adelavega What do you think? I'm not worried about the failing test. Seems one-off and other branches are passing.

Rendered version at https://fitlins--375.org.readthedocs.build/en/375/estimators.html

@Shotgunosine
Copy link
Collaborator Author

@effigies, looks good to me!

@effigies effigies merged commit e71d762 into poldracklab:dev Jul 28, 2022
@effigies
Copy link
Collaborator

Thanks! And thanks for the first pass on this doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies left review comments

@adelavega adelavega adelavega requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shotgunosine @pep8speaks @codecov-commenter @effigies @adelavega
0