8000 Fix: Multisig calls linked to a proxy account by ap211unitech · Pull Request #11412 · polkadot-js/apps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Multisig calls linked to a proxy account #11412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix: Multisig calls linked to a proxy account #11412

merged 1 commit into from
Mar 26, 2025

Conversation

ap211unitech
Copy link
Member

📝 Description

The current polkadot-js explorer has a bug where MultiSig calls fail to execute properly under specific conditions.

🤔 Steps to Reproduce

  1. Use a multisig account that also has an associated proxy account.
  2. Attempt to perform a transaction without using the proxy (i.e., select "Don't use a proxy call for this call").
  3. The UI gets stuck on the loading icon over the "Sign and Submit" button, making it unresponsive.
  4. The only workaround previously was to remove the proxy account from the explorer.

✅ Fix Implemented

  • Identified and resolved the root cause of the issue, ensuring proper handling of multisig transactions regardless of proxy usage.
  • Updated transaction submission logic to prevent UI from freezing.
  • Ensured that the "Sign and Submit" button remains functional in all cases.

🔥 Testing

  • Conducted thorough testing covering all possible cases to prevent recurrence of this issue.
  • Verified successful execution of MultiSig transactions with and without an associated proxy account.
  • Ensured the UI remains responsive and functional under all conditions.
  • This fix enhances the reliability of MultiSig transactions within polkadot-js explorer.
  • Users are no longer required to remove the proxy account as a workaround.

Proxy exists but not using proxy for signing

Screen.Recording.2025-03-21.at.15.10.34.mov

Using Proxy for signing

Screen.Recording.2025-03-21.at.15.13.29.mov

@ap211unitech ap211unitech self-assigned this Mar 21, 2025
This was referenced Mar 21, 2025
Closed
Closed
This was linked to issues Mar 21, 2025
Unable to execute multisig call #10913
Closed
Multisig calls fail when linked to a proxy account. #10975
Closed
TarikGul
TarikGul approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member
@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ap211unitech ap211unitech merged commit 8352b02 into master Mar 26, 2025
5 checks passed
@ap211unitech ap211unitech deleted the fix/multisig-proxy-call branch March 26, 2025 04:09
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@valentinfernandez1 valentinfernandez1 Awaiting requested review from valentinfernandez1

Assignees

@ap211unitech ap211unitech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multisig calls fail when linked to a proxy account. Unable to execute multisig call
3 participants
@ap211unitech @polkadot-js-bot @TarikGul
0