Refactor: Vote component #11540
Merged
Refactor: Vote component #11540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
10 tasks
filvecchiato
approved these changes
May 9, 2025
valentinfernandez1
approved these changes
May 12, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR addresses a bug where transactions with a
Nayvote are incorrectly displayed asAyein the Submission tab of the UI. The bug occurs during the decoding process after switching tabs, even though the underlying transaction data remains correct.The issue is with the
Votetype itself, not just theaye. Even if we changeConvictionvalue and switch back to submission tab, it resets toNone.Encoded call - 0x1400c8000400e87648170000000000000000000000
🤔 Previous Behavior
✅ Current Behaviour
🖋️ Note
Here is one successful transaction with current flow (on Paseo) - https://paseo.subscan.io/extrinsic/0x543a94bbf3d5d9637b1baa7adfa6909df65466709ca2a6aee80347536ab55530