Improve amount error calculation by considering OpenGov-related locks #11578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinfernandez1
approved these changes
May 26, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR addresses an issue where users attempting to join a nomination pool via the UI were not able to contribute tokens locked in OpenGov. While the UI allowed joining the pool, it incorrectly excluded tokens locked for governance participation. The same action can be performed successfully through the Extrinsics page, which clearly indicates a bug in how the UI calculates eligible token amounts.
On Polkadot and its parachains, governance-locked tokens can be used in other staking-related operations. The issue was specific to how balances were computed or filtered on the client side when constructing the join pool extrinsic.
✅ Fixes
🤔 Previous behaviour
Here is the account details used for testing, which have 40 PAS locked in OpenGov.
Previously, the tokens locked in OpenGov are not allowed via UI.
🤔 Current behaviour
https://paseo.subscan.io/extrinsic/6586467-2
Screen.Recording.2025-05-26.at.11.29.08.mov