8000 Handle Import/Export of In-browser accounts gracefully by ap211unitech · Pull Request #11669 · polkadot-js/apps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Handle Import/Export of In-browser accounts gracefully #11669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ap211unitech
Copy link
Member

📝 Description

Since the Accounts page already supports importing and exporting accounts, this PR focuses on addressing existing discrepancies and ensuring the feature works as expected.

In the app, the following account types are supported: in-browser, chopsticks, hardware, injected, multisig, proxied, QR, and testing. These represent the possible sections an account can fall under. Ultimately, every account fits into one of these categories. Among them, only in-browser, multisig, and QR accounts can be exported.

Screen.Recording.2025-07-02.at.12.51.35.mov

@valentinfernandez1
Copy link
Contributor

Why are "testing" accounts not allowed?

@ap211unitech
Copy link
Member Author

Why are "testing" accounts not allowed?

The only reason is that they are not specific to a single user. Their mnemonic or private key can be easily found on the web—for example, for accounts like Alice or Bob. They don't carry real significance for any individual user IMO.

@ap211unitech ap211unitech requested a review from rajk93 July 10, 2025 04:32
Copy link
Contributor
@rajk93 rajk93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Awesome work 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior when importing account metadata
3 participants
0