Volume Control #83
Open
Volume Control #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change
2CE3
the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options in pgusinit for
/mainvol
/oplvol
/sbvol
/gusvol
/psgvol
Notes: OPL has been gained by 4x on the source which should level it out close to line level when maxed out or there is instrument accumulation. I think the original implementation had attenuated the output for plenty of head room. Clipping is still possible on the output, but can be attenuated properly with /oplvol x.
Sound Blaster input volume has also been reduced to 50% to balance it out with line level output. I think this is correct since it was heavily distorting the output on some games. This seems to be balanced closer to GUS and OPL now.
One additional change that snuck in is here Check rate change . This just checks to see if the rate has changed before adjusting so that it is not happening on every loop through. Should be fine and add a small amount of optimization, but worth noting so you are aware of the change.