8000 Wireless Module fails when the SSID is an emoji · Issue #1367 · polybar/polybar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Wireless Module fails when the SSID is an emoji #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lyneca opened this issue Aug 8, 2018 · 7 comments
Closed

Wireless Module fails when the SSID is an emoji #1367

lyneca opened this issue Aug 8, 2018 · 7 comments

Comments

@lyneca
Copy link
lyneca commented Aug 8, 2018

I have my phone's hotspot SSID set to "😶". This displays fine in my terminal and other wifi indicators.
On Polybar's wireless-network module, when connected to this network, it shows the label-disconnected label, despite the internet being connected. This does not happen when I change the SSID of my phone's hotspot to something other than "😶".

Yes, I realise how niche of an issue this is. Is this a Polybar problem or something else? I believe that I updated Polybar quite recently, and that may have been the cause of this problem.

@NBonaparte
Copy link
Member
NBonaparte commented Aug 8, 2018

We recently switched to iw from libnl as the default wireless backend, so it seems like iw might be the issue (if you have it installed).

@lyneca
Copy link
Author
lyneca commented Aug 8, 2018

Could be. I'll have a look in a bit.

@lyneca
Copy link
Author
lyneca commented Aug 9, 2018

Here's what iwgetid returns:

$ iwgetid
wlp2s0    ESSID:"\xF0\x9F\x98\xB6"

@taschenb
Copy link
Contributor
taschenb commented Aug 9, 2018

The libnl implementation does filter out any character in the SSID, that is not printable by the currently installed C locale. This probably interferes with something like emojis.

By disabling this filter and passing through everything the kernel provides should fix this

@lyneca
Copy link
Author
lyneca commented Aug 22, 2018

I'm still having the same problem after updating; when connected to a network with an emoji SSID, the module label is set to label-disconnected, and the IP address doesn't show.

@taschenb
Copy link
Contributor

Are you using netlink (libnl-genl) or WEXT (wireless-tools) as wifi backend for polybar?

Currently you can build it with both. While the build process prefers libnl, it will automatically fall back to the deprecated WEXT in case the dependencies (libnl-genl) for libnl are missing.

As for the issue: I cannot reproduce this with libnl. A single emoji as SSID is sufficient for the connection to be recognized as connected.

You could test both backends by explicitly enforcing them with adding -DWITH_LIBNL=ON or -DWITH_LIBNL=OFF to your cmake command after you have cleaned your build directory.
In case the dependencies are not installed for the specified backend, the network module won't be included in the build. So make sure to install them first.

@lyneca
Copy link
Author
lyneca commented Aug 24, 2018

Compiling with -DWITH_LIBNL=ON works for me!

patrick96 added a commit that referenced this issue Dec 23, 2018
### Breaking Changes:
None

### Changelog

**New Config Options**
The following config options were added

In the `[settings]` section:
* `pseudo-transparency`

In `internal/cpu`:
* `ramp-coreload-spacing`, spacing between elements in `<ramp-coreload>` elements
* `%percentage-sum%` in `label`. Shows sum of all percentages

In `custom/script`:
* `double-click-left`
* `double-click-middle`
* `double-click-right`

In `internal/pulseaudio`:
* `interval`, volume increase and decrease steps in percentage points

In `internal/memory`:
* `bar-swap-used`
* `bar-swap-free`
* `ramp-swap-used`
* `ramp-swap-free`

**Deprecations**
* `tray-transparent` in the bar section is no longer used. The tray now always uses pseudo-transparency

**Features**
* volume: adjustable volume steps (#1364), see #1361
* memory: Add progress bars and ramps for swap (#1325)
* render: pseudo-transparency (always used in the tray)  (#595)
* cpu: 
    * Configurable spacing in between coreloads (#1472), see #1389
    * Non-normalized cpu load (#1517), see #1516
* script: Double click actions (#1442)
* net: Support for bridge interfaces (#1528), see #1522
* token: zero pad tokens when min-width value starts with a `0` (#1341), see #1332

**Fixes**
* config: Use font patterns detected on system in sample config (#1350)
* net: Disconnected module when SSID is only an emoji (#1371), see #1367
* tray: Tray overlapping with bar (#1392), see #591
* build: Several build errors (#1395, #1454, #1470, polybar/xpp#12, #1493), see #1447, #1469, #750, #1492
* mpd: format-online-prefix not working (#1402), see #1399
* font: Crash for some font-patterns (#1451), see #1435
* script: 
    * Only `%counter%` or `%pid%` token usable, never both (#1456)
    * click actions with colons in them (#1457), see #984
* renderer: Bar locks up when xorg composite extension is disabled (#1430), see #1425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
0