8000 Polybar can't compile due to issue with upstream curl · Issue #647 · polybar/polybar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Polybar can't compile due to issue with upstream curl #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jul 12, 2017 · 11 comments
Closed

Polybar can't compile due to issue with upstream curl #647

ghost opened this issue Jul 12, 2017 · 11 comments

Comments

@ghost
Copy link
ghost commented Jul 12, 2017

[ 75%] Building CXX object bin/CMakeFiles/polybar.dir/utils/http.cpp.o
/home/gregf/.cache/pacaur/polybar-git/src/polybar/src/utils/http.cpp:2:10: fatal error: 'curl/curlbuild.h' file not found
#include <curl/curlbuild.h>
^~~~~~~~~~~~~~~~~~
[ 76%] Building CXX object bin/CMakeFiles/polybar.dir/utils/i3.cpp.o
1 error generated.
make[2]: *** [bin/CMakeFiles/polybar.dir/build.make:1359: bin/CMakeFiles/polybar.dir/utils/http.cpp.o] Error 1

Seems like <curl/buildcurl.h> has been removed from upstream and this is breaking the compilation.
I tried removing the offending include statement and compilation was successful.
@patrick96
Copy link
Member

Thanks for reporting. The curlbuild file was removed in commit curl/curl@73a2fce which is not part of any release yet.
I will submit a PR to remove the include since on my system which still has the curl/curlbuild.h file it compiles fine without it.

patrick96 added a commit to patrick96/polybar that referenced this issue Jul 12, 2017
@patrick96
Remove curlbuild include
bff8bcd 
Curl removed that header in 73a
8000
2fcea0b4adea6ba342cd7ed1149782c214ae3
([1])
http.cpp doesn't use anything from that header and compilation works for
fine with curl 7.54.1

Fixes polybar#647
Ref:
[1]: curl/curl@73a2fce
@patrick96 patrick96 mentioned this issue Jul 12, 2017
Merged
@ghost
Copy link
Author
ghost commented Jul 12, 2017

I came across this from the Arch AUR, how do I go about requesting that package also be updated?

@patrick96
Copy link
Member

Which package do you want updated?

@ghost
Copy link
Author
ghost commented Jul 12, 2017 •
edited by ghost
Loading

https://aur.archlinux.org/packages/polybar/ ?
New to this stuff so sorry for my ignorance.

Package maintainer in AUR is also Jaagr if that matters.

@patrick96
Copy link
Member

The package you linked is currently on the newest version of polybar.
If you want to always use the most up date commits, install https://aur.archlinux.org/packages/polybar-git

If you're asking how you can request that the bug with the curl/curlbuild.h is fixed, then posting it here was the right thing to do. I have already fixed it and sent it to jaagr to merge into this repo (see #648). Once it is merged, you can update polybar-git and it will compile successfully

@ghost
Copy link
Author
ghost commented Jul 12, 2017

Awesome, thanks mate! :)

jaagr pushed a commit that referenced this issue Jul 14, 2017
@patrick96 @jaagr
Remove curlbuild include
d35abc7 
Curl removed that header in 73a2fcea0b4adea6ba342cd7ed1149782c214ae3
([1])
http.cpp doesn't use anything from that header and compilation works for
fine with curl 7.54.1

Fixes #647
Ref:
[1]: curl/curl@73a2fce
@ryanseipp ryanseipp mentioned this issue Aug 15, 2017
Closed
@mrkgnao mrkgnao mentioned this issue Aug 19, 2017
Closed
@yorickvP
Copy link

There should probably be a new release with this in, it started failing to build on nixos.

8000

@patrick96
Copy link
Member

Yes there should, but currently the master branch has some issues and also I think jaagr is really busy at the moment

@AndreasBackx AndreasBackx mentioned this issue Sep 2, 2017
Closed
@hubbcaps
Copy link
hubbcaps commented Oct 6, 2017

any possibility of getting traction on this on master? This is still failing on gentoo under the only up to date portage overlay at the moment, having to revert to an unlisted, unofficial overlay to get an older working build currently.

@yorickvP
Copy link
yorickvP commented Oct 6, 2017

@patrick96 maybe make a release branch?

@patrick96
Copy link
Member

@hubbcaps The fix for the build issue has been in master for a few months already.
If you are building against the 3.0.5 tag, then you can cherry pick the commit that fixes it before building:

git cherry-pick -n d35abc7620c8f06618b4708d9a969dfa2f309e96

patrick96 added a commit that referenced this issue Dec 3, 2017
@patrick96
Release 3.1.0 (#863)
bf16a4d 
Breaking Changes:

* Date module no longer supports non-padded specifiers (i.e. `%-d`) and potentially other specifiers, see #792
  - Check http://en.cppreference.com/w/cpp/io/manip/put_time to see supported specifiers
* Setting background color to `background-0` with gradients (refer to https://github.com/jaagr/polybar/wiki/Known-Issues)

Changelog:

Features:
* Feat(mpd): State-specific formats (`format-playing`, `format-paused`, `format-stopped`) (#567), see #524 
* Feat(ipc): Visibility commands (show, hide, toggle, restart, quit) (b6c5563)
* Feat(shell): Bash completion (#588)
* Feat(menu): `expand-right` option (#658), see #655
* Feat(temperature): hwmon sysfs support (#688), see #404 
* Feat(cursor): Change cursors over clickable/scrollable areas (#727), see #721  
* Feat(temperature): Fahrenheit and Celsius tokens (#804)
* Feat(mpd): Use mpd name tag or URI as fallback for title-less tracks (#823), see #815 

Fixes:
* Fix(i3): Clicking workspaces without index (#521), see #520 
* Fix(parser): Prefix options overriding format options (#729), see #544
* Fix(parser): Overline tags (eebf105)
* Fix(process_util): Prefix shell environment variable (`$POLYBAR_SHELL`) (86ff947), see #566 
* Fix(parser): `%{R}` tag (reverse colors) (0bd8f1f), see #585 
* Fix(renderer): Center block position with tray (389bae2 & #673), see #551 & #672 
* Fix(xworkpaces): Active workspace with XMonad (#587), see #411 & #535 
* Fix(config): Expand tilde, environment variable (d3b0670 & #724), see #603 & #719 
* Fix(build): Remove curlbuild.h (#648), see #647 
* Fix(renderer): Off by one error for actions (#663), see #661 
* Fix(gcc): GCC 7.1 ([jaagr/xpp/#6](polybar/xpp#6))
* Fix(fs): Use `bytes_available` for `percentage_used` (138f5fa), see #710
* Fix(fs): Use `f_frsize` for calculations (a682d2a)
* Fix(date): Remove date string length limitation (#745), see #754 
* Fix(renderer): Nested actions (#772), see #760 and #758
* Fix(i3): Check and warn if current workspace not found (#826), see #824 
* Fix(github): Prevent module disappearing with no connection (#811), see #810 
* Fix(renderer): Module gradients (#831), see #759 
* Fix(build): Update deprecated jsoncpp Reader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yorickvP @patrick96 @hubbcaps
0