8000 add custom ssd height by cramt · Pull Request #865 · pop-os/libcosmic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add custom ssd height #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add custom ssd height #865

wants to merge 1 commit into from

Conversation

cramt
Copy link
@cramt cramt commented May 1, 2025

add option for pop-os/cosmic-epoch#275

@cramt cramt mentioned this pull request May 1, 2025
Open
@mmstick
Copy link
Member
mmstick commented May 1, 2025 •
edited
Loading

There is already a header size config here: https://github.com/pop-os/libcosmic/blob/master/src/config/mod.rs#L98-L99

@cramt
Copy link
Author
cramt commented May 1, 2025 •
edited
Loading

There is already a header size config here: master/src/config/mod.rs#L98-L99

yes but that doesnt solve the issue i linked of having no SSD

it could also be a boolean of "ssd_enabled" or something but i initially just went with the more customizable option

@git-f0x
Copy link
Contributor
git-f0x commented May 20, 2025

ssd_enabled should be a compositor config option, since it can just not use the header bar if false.
The compositor sets SSD height on its own, and reducing SSD height would visually break window control buttons (it could only be reduced to 32 without visual bugs), so changes likely aren't needed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cramt @mmstick @git-f0x
0