8000 Incorrect icons in beatmap details window · Issue #13968 · ppy/osu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Incorrect icons in beatmap details window #13968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jkl2k2 opened this issue Jul 21, 2021 · 4 comments
Closed

Incorrect icons in beatmap details window #13968

jkl2k2 opened this issue Jul 21, 2021 · 4 comments
Labels
area:overlay-beatmap good first issue A good place to start contributing to this project without going too deep. priority:3 Nice to have, at some point

Comments

@jkl2k2
Copy link
jkl2k2 commented Jul 21, 2021

Describe the bug: When viewing beatmap details (hitting the "Details..." button on a map after right clicking it), the icons representing BPM, circle count, and slider count have incorrect icons next to their values. They just show a blank circle icon.

Screenshots or videos showing encountered issue:
osu_2021-07-21_12-28-38

osu!lazer version: 2021.720.0-lazer

Logs:
database.log
performance.log
runtime.log
updater.log
@bdach
Copy link
Collaborator
bdach commented Jul 21, 2021

Considering the impending redesign at #13712, this is probably pretty low priority as these icons look to be gone from the new design. But I suppose if someone wants to get their feet wet in lazer development then this is about as good a task as any. The proper icons are defined here.

@bdach bdach added area:overlay-beatmap good first issue A good place to start contributing to this project without going too deep. priority:3 Nice to have, at some point labels Jul 21, 2021
@MishterKirby
Copy link

I would like to attempt correcting this

@peppy
Copy link
Member
peppy commented Jul 22, 2021

The reason they are "wrong" is because the correct icons are not in the font. You're welcome to update it, but make sure you create a reproducible flow for doing so in the future. You'll need to see how this is done in osu-web (which I think may have since moved to svg).

@danielkariv danielkariv mentioned this issue Aug 15, 2021
Merged
@Theighlin
Copy link

This issue can be closed.

@peppy peppy closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:overlay-beatmap good first issue A good place to start contributing to this project without going too deep. priority:3 Nice to have, at some point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@peppy @bdach @jkl2k2 @MishterKirby @Theighlin
0