8000 Fix tournament client crashing at startup when osu!(stalble) is at ranking screen by peppy · Pull Request #14534 · ppy/osu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix tournament client crashing at startup when osu!(stalble) is at ranking screen #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 28, 2021
Merged

Fix tournament client crashing at startup when osu!(stalble) is at ranking screen #14534

merged 6 commits into from
Aug 28, 2021

Conversation

peppy
Copy link
Member
@peppy peppy commented Aug 28, 2021

Closes #14532.

@bdach bdach self-requested a review August 28, 2021 06:50
@bdach
Copy link
Collaborator
bdach commented Aug 28, 2021

I've tested the scenario given in the issue (setting ipc-state.txt contents to Ranking), and I can still reproduce a crash at this line:

osu/osu.Game.Tournament/Screens/Gameplay/GameplayScreen.cs

Line 167 in 69f5705

CurrentMatch.Value.Team2Score.Value++;

due to null CurrentMatch. The test attached does not cover this, because TournamentTestScene sets a CurrentMatch.

@peppy peppy requested a review from TimOliver August 28, 2021 07:29
@bdach
Copy link
Collaborator
bdach commented Aug 28, 2021

Have pushed a commit to fix an issue with the latest changes in TestSceneTeamWinScreen (after changing it to use [Test] instead of BDL, there were naked calls to this.Add() that are valid in BDL but very much not in a test method, wherein it raises an InvalidThreadForMutationException).

Rest seems good.

@peppy peppy merged commit 6f03f7a into ppy:master Aug 28, 2021
@peppy peppy removed the request for review from TimOliver August 28, 2021 08:44
@peppy peppy deleted the fix-tournament-startup-crash branch August 30, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:tournament size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullReferenceException in GameplayScreen when handling ipc on startup when ipc-state.txt has value "Ranking"
2 participants
@peppy @bdach
0