Hide unnecessary lines on empty BeatmapInfoWedge #1720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding back deleted line ooops meh
5af4b93 to
214154c
Compare
|
I'd prefer if you avoided references to Also further visual tests would be much appreciated in any area of the game (I'm really hoping we can get much more coverage in tests). |
determine content by data that is present instead
also fix Author showing when not wanted
1) waiting for loading to finish so Drawables are all present to do asserts on 2) fix NullRef in ResultPage because of removed line in DummyWorkingBeatmap (author one)
|
I've checked with flyte and we both agree that the information should not move vertically even if other pieces are not available. It feels very weird switching between beatmaps where the vertical positioning of text fades to a new location |
|
I'm going to look into preventing that then. (Soon™) |
|
The additional tests added in this PR are useful, at least. |
|
Can you try this? It doesn't move anymore and is only half a pixel off the original position. |
d859ae6 to
3182c22
Compare
peppy
approved these changes
Dec 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugged me for a while. It hides the unnecessary lines for author and other beatmap stats if there is no real beatmap loaded.
If this is worth exploring I'd also continue on this and look into expanding tests on the BeatmapInfoWedge.