Implement sheared text box with filter count and use in multi/playlists lounge #29910
Conversation
|
That vertical caret looks so out of place... at very least it needs more padding, at most it needs actual design thought (I assume an active state was not included in the design, so this should be added / provided cc @arflyte). |
|
Caret is one thing but I'm not sure what this alignment is supposed to be in general: It's so disjointed. Nothing is aligned to anything. Why is the count text further away from the edge rather than closer to follow the shearing? |
|
Apparently there's @ppy/team-design so pinging for help. There's only this figma design (see below screen), but it's missing an active state with the caret and has problems mentioned above. |
|
Here's to provide additional context for the search bar. Hopefully this helps. |
|
@arflyte what about the caret? it doesn't look to even be present in the designs. |
|
Figma file updated with carets |
To be used in song select redesign also, but demonstrating it in playlists/multi as that has the newer
OverlayColourProvider/sheared design, and may look out of place in current song select design:Unsure about the code. Made a separate
ShearedFilterTextBoxinstead of incorporating it into the base as there may be cases where the filter count doesn't make sense. Like maybeModSelectOverlayunless it makes sense to add the count there too.