8000 Add "Require perfect hits" option for Mania Perfect mod by fredzio2006 · Pull Request #33011 · ppy/osu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add "Require perfect hits" option for Mania Perfect mod #33011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2025

Conversation

fredzio2006
Copy link
Contributor
@fredzio2006 fredzio2006 commented May 2, 2025

Currently in the Perfect mod for mania, there is no option to trigger a fail when scoring "Great" hits. This PR adds an option to trigger a fail when getting imperfect score.
osu!_VH54EEm8y1

Example

With the option:

With.the.option.enabled.mp4

Without the option:

Without.the.option.enabled.mp4

@Thepuppetqueen57

This comment was marked as spam.

Copy link
Collaborator
@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test coverage in this class

@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 7, 2025
@fredzio2006 fredzio2006 requested a review from bdach May 7, 2025 19:32
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 8, 2025
Copy link
Collaborator
@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine but I am not merging on my own

@bdach bdach requested a review from a team May 8, 2025 05:50
@fredzio2006 fredzio2006 changed the title Add "Only allow perfect hits" option in Perfect mod for mania Add "Require perfect hits" option for Mania Perfect mod May 8, 2025
@peppy peppy merged commit 7d596a5 into ppy:master May 13, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
2A41
0