SongSelectV2: Refactor test scenes to have a place for non-filtering tests #33105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
commented
May 12, 2025
Comment on lines
+78
to
+92
| protected override IReadOnlyDependencyContainer CreateChildDependencies(IReadOnlyDependencyContainer parent) | ||
| { | ||
| var dependencies = new DependencyContainer(base.CreateChildDependencies(parent)); | ||
|
|
||
| // These DI caches are required to ensure for interactive runs this test scene doesn't nuke all user beatmaps in the local install. | ||
| // At a point we have isolated interactive test runs enough, this can likely be removed. | ||
| dependencies.Cache(Rulesets = new RealmRulesetStore(Realm)); | ||
| dependencies.Cache(Realm); | ||
| dependencies.Cache(Beatmaps = new BeatmapManager(LocalStorage, Realm, null, Dependencies.Get<AudioManager>(), Resources, Dependencies.Get<GameHost>(), Beatmap.Default)); | ||
| dependencies.Cache(Config = new OsuConfigManager(LocalStorage)); | ||
|
|
||
| dependencies.CacheAs<BeatmapStore>(beatmapStore = new RealmDetachedBeatmapStore()); | ||
|
|
||
| return dependencies; | ||
| } |
There was a problem hiding this comment.
This has intentionally been moved from BDL as this is an early spot to cache dependencies before components of the test scene are loaded (particularly the nested GlobalActionContainer inside of the manual input manager, so that default keybinds are matched when inputting keys in tests).
There was a problem hiding this comment.
i still think this is far too much coupling to other components for song select testing. things like toolbar, footer, etc.
but it is what it is for now i don't have the time or energy to improve things.
peppy
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is to move
TestDeleteHotkeyaway from the filtering test scene, and have a house for upcoming hotkey and non-filtering tests, all which depend on isolated database (not only for beatmap import, but also to not fail due to local key binding reconfigurations).