Fix letterbox overlay potentially fading incorrectly during seeks #33111
Conversation
I did not listen to this, because this fix made no sense to me, and I'll let you be the judge of whether that was the correct move, because as far as I can tell (from the fact that I reproduced the issue) this diff does nothing and the actual fix is diff --git a/osu.Game/Screens/Play/LetterboxOverlay.cs b/osu.Game/Screens/Play/LetterboxOverlay.cs
index 565806528a..6bfcf454ed 100644
--- a/osu.Game/Screens/Play/LetterboxOverlay.cs
+++ b/osu.Game/Screens/Play/LetterboxOverlay.cs
@@ -12,6 +12,8 @@ namespace osu.Game.Screens.Play
{
public partial class LetterboxOverlay : CompositeDrawable
{
+ public override bool RemoveCompletedTransforms => false;
+
public required BreakTracker BreakTracker { get; init; }
private readonly Container fadeContainer;
|
|
I explicitly do not want to use that flag on new components, so I'll reassess this.
it definitely doesn't do nothing, the logic behind the fix is sound. |
|
It doesn't fix the issue that I'm seeing, that's for sure. |
abb657d to
866333c
Compare
|
I've gone with the |
Pushing this out with zero testing as a "probably fixes" ppy#33108. Previous logic would mean that the start value of the fade-in may not be zero depending on current state, leaving the final alpha state incorrect after a rewind beyond the start time.
866333c to
83891b1
Compare
Pushing this out with zero testing as a "probably fixes" #33108.
Previous logic would mean that the start value of the fade-in may not be zero depending on current state, leaving the final alpha state incorrect after a rewind beyond the start time.
Hope for an immediate merge with no further testing based on "yeah that's probably correct".