3 display banner and video vast support for rads #4209
Conversation
modules/stvBidAdapter.js
Outdated
| const videoData = utils.deepAccess(bidRequest, 'mediaTypes.video') || {}; | ||
| const sizes = utils.parseSizesInput(videoData.playerSize || bidRequest.sizes)[0]; | ||
| const width = sizes.split('x')[0]; | ||
| const height = sizes.split('x')[1]; |
There was a problem hiding this comment.
can move this to one line const [width, height] = sizes.split('x');
modules/stvBidAdapter.js
Outdated
| const bidResponses = []; | ||
| const response = serverResponse.body; | ||
| const crid = response.crid || 0; | ||
| const cpm = response.cpm / 1000000 || 0; |
There was a problem hiding this comment.
Why are we dividing the response CPM by a million?
modules/stvBidAdapter.js
Outdated
| dealId: dealId, | ||
| currency: currency, | ||
| netRevenue: netRevenue, | ||
| ttl: config.getConfig('_bidderTimeout') |
There was a problem hiding this comment.
This is the TTL for the creative to expire. since it is in bidResponse
So setting this to the config's bidderTimeout seems strange to me.
IS this actually what is wanted by STV bid adapter?
modules/stvBidAdapter.md
Outdated
| { | ||
| bidder: "stv", | ||
| params: { | ||
| placement: "", // placement ID of inventory with STV |
There was a problem hiding this comment.
I am not able to test with these params.
Can you please provide a test placement which will return a video ad?
There was a problem hiding this comment.
@robertrmartinez Could You help me to solve one problem? The STV adapter already merged into master (#3737) but I see its commits in this branch. I don't know how it got into this branch.
Our GitLab changes:
GitHub commits:
We have a Mirror a repository settings in our GitLab application. What could happen and how to fix it?
|
Have you tried to pull the latest of prebid master upstream? On your local try and do a Might catch your branch up with the latest commits you are missing. Otherwise I would just catch your fork up with prebid master, The jsut create a new branch and add your RADS adapter changes to it and then create a new PR which does not have the STV commits and we will push it through. Have not used gitLab so unsure how they handle all this type of stuff, but pretty sure your prebid needs to be fast-forwarded |
…isplay-banner-and-video-vast-support-for-rads
|
@robertrmartinez Thanks a lot for help! I merged branch 'master' of https://github.com/prebid/Prebid.js to this branch and now I see only 3 files with changes. |
Type of change
Description of change
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
prebid/prebid.github.io#1500