GumGum: adds schain param #4442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sumit116 , could you provide an example of where I should set schain_supported=true in the doc file? Should I add that to the description portion? I was reviewing other adapters who are now supporting schain and they didn't have any mentions of schain support in their md file. |
|
@susyt , you can refer to https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/pubmatic.md. This file contains what you need to add i.e |
|
@sumit116 Thanks for the link! here's the other PR for updating the doc - prebid/prebid.github.io#1613 |
sumit116
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds support for supply chain object using IAB's Non-OpenRTB serialization format