8000 LiveIntent Id Submodule: Update live-connect build dependency to 2.3.1 by 3link · Pull Request #8198 · prebid/Prebid.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

LiveIntent Id Submodule: Update live-connect build dependency to 2.3.1 #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2022
Merged

LiveIntent Id Submodule: Update live-connect build dependency to 2.3.1 #8198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea416f6
Update live-connect to 2.3.1
Mar 18, 2022
567844a
Fix tests
Mar 21, 2022
a6b9f8c
Merge branch 'master' into update-live-connect-js-version
Mar 21, 2022
e46c77c
Merge branch 'master' into update-live-connect-js-version
Mar 22, 2022
43f8882
Merge remote-tracking branch 'upstream/master' into update-live-conne…
Mar 29, 2022
cff2957
Update release version
Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
"express": "^4.15.4",
"fun-hooks": "^0.9.9",
"just-clone": "^1.0.2",
"live-connect-js": "2.0.0"
"live-connect-js": "2.3.1"
},
"optionalDependencies": {
"fsevents& 8000 quot;: "^2.3.2"
Expand Down
8 changes: 4 additions & 4 deletions test/spec/modules/liveIntentIdSystem_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('LiveIntentId', function() {
consentString: 'consentDataString'
})
liveIntentIdSubmodule.getId(defaultConfigParams);
expect(server.requests[0].url).to.match(/https:\/\/rp.liadm.com\/j\?wpn=prebid.*us_privacy=1YNY.*&gdpr=1&gdpr_consent=consentDataString.*/);
expect(server.requests[0].url).to.match(/https:\/\/rp.liadm.com\/j\?.*&us_privacy=1YNY.*&wpn=prebid.*&gdpr=1&gdpr_consent=consentDataString.*/);
});

it('should fire an event when getId and a hash is provided', function() {
Expand All @@ -88,7 +88,7 @@ describe('LiveIntentId', function() {
}
}
}});
expect(server.requests[0].url).to.match(/https:\/\/collector.liveintent.com\/j\?aid=a-0001&wpn=prebid.*/);
expect(server.requests[0].url).to.match(/https:\/\/collector.liveintent.com\/j\?.*aid=a-0001.*&wpn=prebid.*/);
});

it('should initialize LiveConnect and emit an event with a privacy string when decode', function() {
Expand Down Expand Up @@ -195,7 +195,7 @@ describe('LiveIntentId', function() {

it('should include the LiveConnect identifier when calling the LiveIntent Identity Exchange endpoint', function() {
const oldCookie = 'a-xxxx--123e4567-e89b-12d3-a456-426655440000'
getDataFromLocalStorageStub.withArgs('_li_duid').returns(oldCookie);
getCookieStub.withArgs('_lc2_fpi').returns(oldCookie)
let callBackSpy = sinon.spy();
let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback;
submoduleCallback(callBackSpy);
Expand All @@ -211,7 +211,7 @@ describe('LiveIntentId', function() {

it('should include the LiveConnect identifier and additional Identifiers to resolve', function() {
const oldCookie = 'a-xxxx--123e4567-e89b-12d3-a456-426655440000'
getDataFromLocalStorageStub.withArgs('_li_duid').returns(oldCookie);
getCookieStub.withArgs('_lc2_fpi').returns(oldCookie);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the PR description I find it surprising that you'd change these from local storage to cookies - but if it makes sense to you (& the rest of the maintainers) I have no issue with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgirardi The resulting behaviour did not change. A step for building the request was refactored and the dependency on the _lc2_fpi cookie being present became more obvious in the test. It was there before too, but it was enough to stub getDataFromLocalStorage.

getDataFromLocalStorageStub.withArgs('_thirdPC').returns('third-pc');
const configParams = { params: {
...defaultConfigParams.params,
Expand Down
0