Added support for NURL and ADM responses #2031
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added version number + Updated unit tests
Adding districtm as an alias since it was also an alias in the previous Prebid version.
* GumGum Adapter for Prebid.js 1.0 * removed getUserSyncs. Give cpm a non-zero value when bidRequest is for test unit so DFP chooses it. * parsing slot ID as integer from params * ADSS-78 removed bidderCode from response. Correctly parsing bidRequest.sizes to account for 1-dimensional array.
* 1.0 support for mantis adapter * removed some common non-prebid code * Remove bidderCode to fix failing test
* separate bids & won calls * readd polyfills
…recated mediaType field (prebid#1974)
* Add eplanningBidAdapter * Add new parameter to request * Fix sync URL parameter
* VI prebid.js adapter (points dev platform) * fix typo * Changed maintainer email * Added test parameters * Changed bidder hostname to pb.vi-serve.com * updated doc * Update viBidAdapter.md * VI bid adapter - tests * Removed unused import from spec, specified radix in parseInt * handling of various sizes formats
* Update Atomx adapter for Prebid v1.0 * Add code markup
* first commit * ip field removed, added comments to params, netRevenue set to true also changed surce of end-point to prebid-client from prebid-server * added _processFloor * removed comments * fixed unit test cases * review comments * added method _parseSlotParam removed method _processFloor and _processPmZoneId added const for undefined * minor changes * minor change * publisherId isStr check added * test case for string publisherId and adSlot * using prebid apis for getting pageURL and refURL, added a small function to find domain from given url * bid precision set to 2 * Added test cases for interpretResponse function * do not put warning for undefined valued params * changes for UOE-3239 and UOE-3236 * Linting errors fixed * Add geo object in device * Changes to trim kadpageurl and pmzoneid before sending it in request * Remove spaces when multiple Id's added in pmzoneId * rolling back changes for pmzoneid * Add PubMaticBidAdapter param info * Update params in pubmaticBidAdapter.md * Update maintainer mail-id * endpoint changed to hbopenbid.pubmatic.com, netRevenue default value changed to false, test cases updated * changed auction type to 1 * changed at to 1 in test cases * removed comments * UserSync requirements are mentioned in .md file * updated test ids
* Update adapter to prebid v1.0 * corrected some things following pullrequest review * slight change to avoid potential error * added the maintainer email * Updated the tests to fit changes * Updated the doc, removed the bidderCode, added adUrl * fix adapter * Added try catch around JSON.parse
* initial version * Initial implementation for Inskin/AdZerk bid adapter. * Add required ad types and fix event IDs list. * InSkin Bid Adapter: fixed tests and linter errors * InSkin Media: updated test parameters * InSkin Media: Add maintainer
* create adapter colossusssp * Trigger for current build rerun on Travis CI
…prebid#1976) * initial version of pre1api module to allow use of deprecated API in 1.0 * move cbTimeout to config rather than auction properties * fix bug in auction queueing for pre-1.0 api module * updated doc comment for pre-1.0 api module * set next function correctly if requestBids is called w/ no arguments
* Populate ad_types array on all requests * Remove descriptionUrl * Allow a bidder to participate on an adunit if it supports at least one of the mediaTypes * Add hb_mediatype to standard targeting * Determine when to trigger callback based on bid response * Change key to hb_format * Print banner as default when mediaTypes not defined * Update spportedMediaTypes to include banner for adapters that were implicitly supporting banner
* Optimera Adapter for 1.0. * Optimera Adapter updating for json endpoint. * Optimera Adapter removing custom params property.
…1977) * RockYou Adapter: Added RockYou Adapter supporting Prebid 1.0 * RockYou Adapter: Removed extraneous imports, replaced a for loop w/ forEach for variable scoping. * RockYou Adapter: Updated the size handling to allow for multiple size definitions to be handled successfully
* Add PlatformioBidAdapter * Update platformioBidAdapter.js * Add files via upload * Update hello_world.html * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Update hello_world.html * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update hello_world.html * Add files via upload * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Update platformioBidAdapter * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js Endpoint URL change * Update platformioBidAdapter_spec.js Endpoint URL change * Update platformioBidAdapter_spec.js * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload
* xendizBidAdapter * Prebid endpoint * Drop bidderCode * Sync endpoint update * Test update
* nanointeractive bid adapter * Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;
* Add a new ucfunnel Adapter and test page * Add a new ucfunnel Adapter and test page * 1. Use prebid lib in the repo to keep updated 2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block * utils.getTopWindowLocation is a function * Change to modules from adapters * Migrate to module design * [Dev Fix] Remove width and height which can be got from ad unit id * Update ucfunnelBidAdapter to fit into new spec * Correct the endpoint. Fix the error of query string * Add test case for ucfunnelBidAdapter * Fix lint error * Update version number * Combine all checks on bid request
* Optimize sending requests. * Add integration example. Minor changes.
small adjustment to the user sync mechanism
|
@optimatic58 this needs to be rebased off the latest master. There were some changes that happened that would stop the tests from failing in travis. Thanks! |
* add digitrust support to prebidserverBidAdapter * fixed typo
|
We built this on the master and submitted this 21 days ago. Do we need to rebase it to the latest master and resubmit it with a different ticket? |
* Pass app to Prebid server pbsrequest.go code is indeed developed to read the app fields present in the root of PBSRequest json not in the PBSRequest.ad_units child object. So far no app bundle is passed in the prebid server payload to the differents bidders... With this fix, the device and app should be passed in the setConfig rather than AdUnits. * Update prebidServerBidAdapter.js
|
@optimatic58 you need to rebase off master so that you have the latest, but you don't need to make a separate ticket. If you rebase the source branch for this pull-request ( |
* PR / Issue Review process update * Update pr_review.md * Capitalize filename
* serverbid sync wip * Serverbid Bid Adapter: enable getUserSyncs, new ad sizes
* bid response adId same as bidId * test * update adform bid adapter * update unit tests * Added adform adapter description file * updated tests * Another tests update * Add auctionId * Update adapter for auctionId * add auctionId to adformBidAdapter * Final updates to fit 1.0 version * update docs and integration example * Do not mutate original validBidRequests * use atob and btoa instead of custom made module * Renaming one query string parameter * XDomainRequest.send exception fix (prebid#1942) * Added YIELDONE Bid Adapter for Prebid.js 1.0 (prebid#1900) * Added YIELDONE Bid Adapter for Prebid.js 1.0 * Update yieldoneBidAdapter.md change placementId to 44082 * Changed to get size from bid.sizes * fix sizes array * Add user-facing docs reminder to PR template (prebid#1956) * allow non-mappable sizes to be passed and used in rubicon adapter (prebid#1893) * Typo correction of YIELDONE md file (prebid#1954) * Added YIELDONE Bid Adapter for Prebid.js 1.0 * Update yieldoneBidAdapter.md change placementId to 44082 * Changed to get size from bid.sizes * fix sizes array * Fix a typo * Serverbid bid adapter: update alias config (prebid#1963) * use auctionId instead of requestId (prebid#1968) * Add freewheel ssp bidder adapter for prebid 1.0 (prebid#1793) * add stickyadsTV bidder adapter * init unit test file * ad some unit tests * fix unit test on ad format with parameters * add some unit tests * add unit tests on getBid method * add some test cases in unit tests * minor fix on component id tag. * remove adapters-sticky.json test file * use top most accessible window instead of window.top * Pass in the bid request in the createBid call. * use top most accessible window instead of window.top * add unit tests * update unit tests * fix unit test. * fix CI build * add alias freewheel-ssp * update unit tests on bidderCode value * fix component id values and add unit tests * allws to use any outstream format. * fix ASLoader on futur outstream format versions * minor: fix code format. * update unit tests * minor fix code format * minor: add missing new line at eof * replace StickyAdsTVAdapter by freewheel ssp bd adapter (for prebid 1.0) * remove old stickyadstv unittest spec. * fix server response parsing if sent as object with 'body' field * use the vastXml field for video mediatype * add user sync pixel in freewheel ssp adapter * remove all console log calls (replaced using util helper) * remove useless bidderCode (automatically added by the bidderFactory) * Return the SYNC pixel to be added in the page by Prebid.js * remove instance level properties to enable concurrent bids with the same adapter instance. * fix the request apss through and corresponding unit tests * fix 'freeheelssp' typo * + fixed endpoint request data property names - width to w and height to h (prebid#1955) + updated unit test for the adapter to comply with the property name changes * Added iQM Bid Adapter for Prebid.js 1.0 (prebid#1880) * Added iQM Bid Adapter for Prebid.js 1.0 * Modified URL from http to https * Removed geo function which was fetching user location. * Remove stray console.log (prebid#1975) * Remove duplicate request id and fix empty response from getHighesCpmBids, getAdserverTargeting (prebid#1970) * Removed requestId and added auctionId * Updated module fixtures to use auctionId and not requestId * remove request id from external bid object and fix bug for empty result in public api * use auctionId instead of requestId * fixed lint errors * [Add BidAdapter] rxrtb adapter for Perbid.js 1.0 (prebid#1950) * Add: rxrtb prebidAdapter * Update: params for test * Update: code format * Update: code format * Update: code format * ServerBid Server BidAdapter (prebid#1819) * ServerBid Server BidAdapter Allow S2S configuration with ServerBid. * Updates to meet 1.0 callBids/config changes. * Fix linting issues. * added hb_source to default keys (prebid#1969) * added hb_source * dropped function to add hb_source since it is now default key * fixed lint error * Prebid 1.1.0 Release * Increment pre version * S2s defaults fix in serverbidServerBidAdapter (prebid#1986) * removed s2s defaults * start timestamp was missing on s2s requests * remove hardcoded localhost port for tests (prebid#1988) * Fixes unit tests in browsers other than chrome (prebid#1987) * Fixes unit tests in browsers other than chrome * fixed lint errors * Prebid 1.1.1 Release * Add note about docs needed before merge (prebid#1959) * Add note about docs needed before merge * Update pr_review.md * Update pr_review.md * Update pr_review.md * Adding optional width and height to display parameters (prebid#1998) * adding optional size * no tabs * TrustX adapter update (prebid#1979) * Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net * Update TrustX adapter to support the 1.0 version * Make requested changes for TrustX adapter * Updated markdown file for TrustX adapter * Fix TrustX adapter and spec file * Update TrustX adapter: r parameter was added to ad request as cache buster * Serverbid Bid Adapter: Add new ad sizes (prebid#1983) * Added dynamic ttl property for One Display and One Mobile. (prebid#2004) * pin gulp-connect at non-broken version (prebid#2008) * pin gulp-connect at non-broken version * updated yarn.lock to specify pinned gulp-connect * Gjirafa Bidder Adapter (prebid#1944) * Added Gjirafa adapter * Add gjirafa adapter unit test * adapter update * New line * Requested changes * change hello_world.html to one bid * change hello_world.html to one bid * Dropping changes in gitignore and hello_world example * hello_world changes * Drop hello_world and gitignore * multiformat size validation checks (prebid#1964) * initial commit for multiformat size validation checks * adding unit tests and changes to checkBidRequestSizes function * updates to appnexusBidAdapter * Upgrade Admixer adapter for Prebid 1.0 (prebid#1755) * Migrating to Prebid 1.0 * Migrating to Prebid 1.0 * Fix spec * Add NasmediaAdmixer adapter for Perbid.js 1.0 (prebid#1937) * add NasmediaAdmixer adapter for Perbid.js 1.0 * add NasmediaAdmixer adapter for Perbid.js 1.0 * add NasmediaAdmixer adapter for Perbid.js 1.0 * add NasmediaAdmixer adapter for Perbid.js 1.0 * add NasmediaAdmixer adapter for Perbid.js 1.0 * add NasmediaAdmixer adapter for Perbid.js 1.0 * Updated stid and unit tests
* * bidmanager: pass closure variables explicitly to helper functions in addBidResponse * bidmanager: move addBidResponse helper functions out of closures * WIP: call doCallbacks from addBidToAuction In order to ensure the calling order is correct, call doCallbacks from within addBidToAuction. XXX: This breaks the test that's removed in this patch. The reason it breaks is that the TIMEOUT event is not emitted if all bids have been returned before the timeout handler is called. Previously the bid manager was rejecting the bid if the bid triggered the timeout handler, which doesn't really make much sense. The test SHOULD work if there are two bidders, as the first response should trigger the timeout. I had a hard time adding a second bidder to the test code, so I was hoping to get some help.
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method
+ Added version number + Updated unit tests
…ebid.js into optimatic-adapter
|
@snapwich thanks, we have rebased on the latest master and pushed it. let us know if there is anything else. |
|
Hmmm, I'm not quite sure how you rebased, but it rewrote the commits somehow and that is not good since now git thinks they're all new commits. If it is easier, you may want to try making a new pull-request with just the commits you want. |
|
that's weird... first, we rebased our source master (forked) off upstream master (prebid) to get them synced up and then rebased our optimatic-adapter branch off our master and pushed it. not sure how this created an issue but now that this is done - how do we go about creating a new pull request? We would have to create a new branch off the same master and wouldn't that still carry the same commit history? may be we should have simply merged our master with the prebid upstream master rather than rebase it... regardless any ideas how to proceed? thanks. |
|
Submitted a new pull request - Support for NURL and ADM as backup #2112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
contact email of the adapter’s maintainer
prebid@optimatic.com
official adapter submission