8000 Support aliases in prebidServer by matthewlane · Pull Request #2257 · prebid/Prebid.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support aliases in prebidServer #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2018
Merged

Support aliases in prebidServer #2257

merged 2 commits into from
Mar 26, 2018

Conversation

matthewlane
Copy link
Collaborator
@matthewlane matthewlane commented Mar 12, 2018 •
edited
Loading

Type of change

  • Feature

Description of change

Supports calling bider adapter aliases with prebidServer adapter (OpenRTB endpoint only). In a prebid setup, add a known alias to the s2sConfig.bidders array, and that will take part in the s2s auction.

Example config - known alias

pbjs.setConfig({
  s2sConfig: {
    enabled: true,
    accountId: '123-456',
    endpoint: 'https://prebid.adnxs.com/pbs/v1/openrtb2/auction',
    bidders: ['appnexus', 'brealtime'],
  },
});

// brealtime and appnexusAst are both aliases of appnexus
// appnexus and brealtime will take part in the s2s auction since they are listed in s2sConfig.bidders
// appnexusAst will be run client-side
pbjs.addAdUnits({
    // ...
    bids: [
      {
        bidder: 'appnexus',
        params: { placementId: '123' }
      },
      {
        bidder: 'brealtime',
        params: { placementId: '123' }
      },
      {
        bidder: 'appnexusAst',
        params: { placementId: '456' }
      },
    ],
   // ...
  });

Example config - dynamic alias

pbjs.aliasBidder('appnexus', 'newAlias');

pbjs.setConfig({
  s2sConfig: {
    enabled: true,
    accountId: '123-456',
    endpoint: 'https://prebid.adnxs.com/pbs/v1/openrtb2/auction',
    bidders: ['newAlias'],
  },
});

// newAlias will take part in s2s auction
pbjs.addAdUnits({
    // ...
    bids: [
      {
        bidder: 'newAlias',
        params: { placementId: '123' }
      },
    ],
   // ...
  });

bretg
bretg reviewed Mar 13, 2018
View reviewed changes
Copy link
Collaborator
@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to implement these aliases without tying prebidServerBidAdapter to the appnexusBidAdapter?

@matthewlane
Copy link
Collaborator Author

@bretg Yes, the aliases array can be copied into this file. In that case whenever an appnexus alias is added, modified, or removed, both arrays will need to be edited

mkendall07
mkendall07 requested changes Mar 14, 2018
View reviewed changes
Copy link
Member
@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to be compatible with pbjs.aliasBidder thanks.

@chefbenjamin
Copy link

Any ETA to when this feature might be available ?

@matthewlane matthewlane force-pushed the prebid-server-aliases branch from 14b4349 to 0d4f476 Compare March 16, 2018 22:26
@matthewlane matthewlane changed the title Support AppNexus aliases in prebidServer Support aliases in prebidServer Mar 16, 2018
@matthewlane matthewlane added needs review needs 2nd review Core module updates require two approvals from the core team and removed needs update labels Mar 16, 2018
@mkendall07
Copy link
Member
mkendall07 commented Mar 19, 2018 •
edited
Loading

@bretg
could use a review on this one from Rubicon side.

@bretg bretg requested a review from idettman March 23, 2018 13:56
mkendall07
mkendall07 approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member
@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and clean code!

@mkendall07 mkendall07 merged commit feafdcf into master Mar 26, 2018
@matthewlane matthewlane deleted the prebid-server-aliases branch March 27, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg left review comments

@idettman idettman idettman approved these changes

@mkendall07 mkendall07 mkendall07 approved these changes

Assignees

@mkendall07 mkendall07

Labels
needs review needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthewlane @chefbenjamin @mkendall07 @idettman @bretg
0