Add vastUrl for Gamma Adapter Video #2261
Conversation
removed mediaType in bid and return vastXml property if video request
There was a problem hiding this comment.
Hi @gammassp ,
Overall these changes look good me. I was able to test out the new userSync code you added and saw the request fired off to your endpoint.
I was wondering though if you had a test placement that returned video to check/verify the new vastUrl property you added. I tried the test params in the PR but I was consistently seeing a banner return.
Please let me know when you have the chance.
There was a problem hiding this comment.
The Gamma bidder spec should add
supportedMediaTypes: ['banner', 'video'],(below aliases or anywhere in the spec is fine) since it supports both banner and video formats. See this note in the docs for more info
|
Hi, The supportedMediaTypes added to bidder specs and I have just added test parameters for video
Please check again |
There was a problem hiding this comment.
Thanks @gammassp for making these changes. I tested out the new test params on an instream video test page and it seemed to be working fine.
* master: Audience Network: Add 'pbv' and 'cb' query params (prebid#2252) Add e-planning analytics adapter (prebid#2211) Add vastUrl for Gamma Adapter Video (prebid#2261) update params for test bid (prebid#2267) Updated adUnitCode (prebid#2262) vastUrl is set based on nurl for video. (prebid#2249) Added ad id to a4g bid (prebid#2250) Add billing url (burl) support (prebid#2246) Fix: add mediatype in bid response (prebid#2260) use b64EncodeUnicode to encode strings with unicode chars in them (prebid#2245) create RELEASE_SCHEDULE.md (prebid#2255) Update Platform.io Adapter (prebid#2230) Update Lifestreet adapter to 1.0 (prebid#2197) PBS adapter not sending app or device (prebid#2206) Fix prebid#2229 - Edge cookie string form (prebid#2236) Add Invibes Adapter (prebid#2202)
Type of change
Description of change
Support vastUrl for Video