LiveYield Analytics Adapter DfP Support #3506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRTA-399 Minor reformats impression value fixed changed path to rta params corrections resolveSlot fixed postprocess() param fixed docs update imprVal(), imprPartner() impl added SRTA-399 Docs, no console.log
|
I tried testing this with the test params from #3443 but I'm getting the following error: Could you add a comment with everything I need to get this to run? |
|
Sure thing... you can find the code snippet that you are looking for in the correspnding .md file. Here it is: <script>
(function(i,s,o,g,r,a,m,z){i['RTAAnalyticsObject']=r;i[r]=i[r]||function(){
z=Array.prototype.slice.call(arguments);z.unshift(+new Date());
(i[r].q=i[r].q||[]).push(z)},i[r].t=1,i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','https://tracker.liveyield.com/pubocean-tracker.min.js',
'rta');
</script>after that enable analytics using: Let me know if you need anything more. |
|
I'm getting a test failure: I test with your code on master sometimes these show up because a package was updated since you made the PR. |
|
Thank you for this @mike-chowla - master merged to our branch, fix applied. Tests are passing. Please retest. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Prebid.js quite often (:)) is being used with DfP and as such the final ad impression/revenue reporting shall take this under consideration. This PR allows one to pass DfP level details back to the LiveYield analytics server.