8000 Migrate to header-only yaml by fsimonis · Pull Request #143 · precice/calculix-adapter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate to header-only yaml #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2025
Merged

Migrate to header-only yaml #143

merged 5 commits into from
Jul 8, 2025

Conversation

fsimonis
Copy link
Member
@fsimonis fsimonis commented Jul 4, 2025 •
edited
Loading

This PR replaces the yaml-cpp dependency with the MIT licensed header-only YAML library https://github.com/fktn-k/fkYAML.

Problems installing and finding yaml-cpp are common and the header-only variant will solve a range of troubleshooting steps.

This also reduced the diff of the Makefiles.

@IshaanDesai IshaanDesai self-requested a review July 4, 2025 20:41
IshaanDesai
IshaanDesai reviewed Jul 8, 2025
View reviewed changes
Copy link
Member
@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. It is an important step in increasing the usability of the adapter. I just have a few queries.

IshaanDesai
IshaanDesai approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member
@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with the perpendicular-flap and everything seems to work 👍

@IshaanDesai IshaanDesai merged commit 6f6357b into develop Jul 8, 2025
3 checks passed
@IshaanDesai IshaanDesai deleted the migrate-to-header-only-yaml branch July 8, 2025 12:51
@IshaanDesai IshaanDesai mentioned this pull request Jul 8, 2025
Open
@fsimonis fsimonis linked an issue Jul 9, 2025 that may be closed by this pull request
Use a header-only yaml library #141
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a header-only yaml library
2 participants
@fsimonis @IshaanDesai
0