8000 Release v2.3.0.1 by IshaanDesai · Pull Request #34 · precice/matlab-bindings · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v2.3.0.1 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 11, 2021
Merged

Release v2.3.0.1 #34

merged 16 commits into from
Oct 11, 2021

Conversation

IshaanDesai
Copy link
Member
@IshaanDesai IshaanDesai commented Oct 7, 2021 •
edited
Loading

Release for preCICE v2.3.0

Main features:

BenjaminRodenberg
BenjaminRodenberg requested changes Oct 7, 2021
View reviewed changes
Copy link
Member
@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also run a quick test with the new API functions? No need to do something real, but just calling the functions to ensure they work would be good.

BenjaminRodenberg
BenjaminRodenberg approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member
@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor points. Ready to go from my perspective 🎉

@IshaanDesai IshaanDesai merged commit 6434dc0 into master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikscheurer erikscheurer erikscheurer left review comments

@BenjaminRodenberg BenjaminRodenberg BenjaminRodenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IshaanDesai @BenjaminRodenberg @erikscheurer
0