8000 Fix return type for ZCOUNT by TimWolla · Pull Request #1546 · predis/predis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix return type for ZCOUNT #1546

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

Fix return type for ZCOUNT #1546

merged 2 commits into from
May 27, 2025

Conversation

TimWolla
Copy link
Contributor

ZCOUNT returns an int:

Integer reply: the number of members in the specified score range.

@TimWolla TimWolla requested a review from tillkruss as a code owner May 26, 2025 09:24
@TimWolla
Copy link
Contributor Author

Please advice regarding the CHANGELOG entry. Is sending a PR targeting v2.x even appropriate? I'm seeing main has “Unreleased” in the CHANGELOG, but v2.x does not.

@vladvildanov
Copy link
Contributor

@TimWolla Hi! I think v2.x is CVE and bugfixes only, correct me if I'm wrong @tillkruss

@TimWolla
Copy link
Contributor Author

and bugfixes

I would say that fixing the return type to match the reality is a bugfix 😄

@TimWolla
Fix return type for ZCOUNT
af34bf4 
ZCOUNT returns an `int`:

> Integer reply: the number of members in the specified score range.
@coveralls
Copy link
coveralls commented May 26, 2025 •
edited
Loading

Coverage Status

coverage: 88.834%. first build
when pulling 06cb8e8 on TimWolla:zcount-type
into f49e13e on predis:v2.x.

tillkruss
tillkruss approved these changes May 26, 2025
View reviewed changes
Copy link
Member
@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are checking for integers as well.

@vladvildanov vladvildanov merged commit c4b9c34 into predis:v2.x May 27, 2025
29 checks passed
vladvildanov pushed a commit that referenced this pull request May 27, 2025
@TimWolla @tillkruss @vladvildanov
Fix return type for ZCOUNT (#1546)
1facbdd 
* Fix return type for ZCOUNT

ZCOUNT returns an `int`:

> Integer reply: the number of members in the specified score range.

* Update CHANGELOG.md

---------

Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
@TimWolla TimWolla deleted the zcount-type branch May 27, 2025 10:47
tillkruss added a commit that referenced this pull request May 27, 2025
@vladvildanov @TimWolla @tillkruss
Backport #1546 (#1547)
87e08a3 
* Fix return type for ZCOUNT (#1546)

* Fix return type for ZCOUNT

ZCOUNT returns an `int`:

> Integer reply: the number of members in the specified score range.

* Update CHANGELOG.md

---------

Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>

* Added changelog entry

---------

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimWolla @vladvildanov @coveralls @tillkruss
0