8000 fix(stream): Fixed throwing `CommunicationException` when stream is EOF by vladvildanov · Pull Request #1548 · predis/predis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(stream): Fixed throwing CommunicationException when stream is EOF #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 30, 2025
Merged

fix(stream): Fixed throwing CommunicationException when stream is EOF #1548

merged 6 commits into from
May 30, 2025

Conversation

vladvildanov
Copy link
Contributor

Fixing thrown exception when stream is EOF, as specified in a signature CommunicationException should be thrown

@vladvildanov vladvildanov requested a review from tillkruss as a code owner May 28, 2025 14:35
@coveralls
Copy link
coveralls commented May 28, 2025 •
edited
Loading

Coverage Status

coverage: 92.654% (+0.01%) from 92.642%
when pulling afffc54 on vv-fix-stream-eof
into 6021daf on main.

@vladvildanov vladvildanov changed the title fix(stream): Fixed return type to match function signature fix(stream): Fixed exception type to match function signature May 28, 2025
tillkruss
tillkruss requested changes May 28, 2025
View reviewed changes
@vladvildanov vladvildanov changed the title fix(stream): Fixed exception type to match function signature fix(stream): Fixed throwing CommunicationException when stream is EOF May 29, 2025
@vladvildanov vladvildanov merged commit d7f6009 into main May 30, 2025
25 checks passed
@vladvildanov vladvildanov deleted the vv-fix-stream-eof branch May 30, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladvildanov @coveralls @tillkruss
0