Add stamp, stamp-to commands
#954
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These commands modify the version table without actually running any migrations. The command names are taken from alembic [1], but other frameworks also support this under different names (repair, force, ...), see pressly#938. The `stamp` command simply sets the database version to that of the latest available migration, where as the `stamp-to` command allows to specify a version (including 0). Stamping can both increase and decrease the database version. [1]: https://alembic.sqlalchemy.org/en/latest/api/commands.html#alembic.command.stamp Fixes: pressly#938
|
Hi there, thank you for your work on goose! We really like it and are in the process of migrating over from alembic, hence the choice of command naming. However, I'd be totally open to give these commands any other name 🙂 we'd just be super happy to see this functionality added to goose! I have tested the functionality with a simple project, and it handled all of the cases I could think of. However, this was my first time looking at goose internals, so I may have missed a bunch of stuff. If you'd be up for including this functionality at all I am happy to spend time refining this PR to your liking! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commands modify the version table without actually running any migrations. The command names are taken from alembic, but other frameworks also support this under different names (repair, force, ...), see #938.
The
stampcommand simply sets the database version to that of the latest available migration, where as thestamp-tocommand allows to specify a version (including 0). Stamping can both increase and decrease the database version.Fixes: #938