10000 fix(lang): use local refs for repo resolution to bypass authentication by princjef · Pull Request #12 · princjef/gomarkdoc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(lang): use local refs for repo resolution to bypass authentication #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

princjef
Copy link
Owner
@princjef princjef commented Feb 5, 2020

The existing code calls remote.List() to get the list of branches per remote. However, this call actually fetches the branches from the remote. Doing so both slows the call down and requires authentication, which requires extra configuration and is not always set up.

This change switches to listing references on the repository itself, which requires no fetch from the remote and therefore no authentication, while still being able to find the refs on the remote and determine the default branch.

@princjef princjef force-pushed the repo-auth-fix branch 18 times, most recently from 16b47fa to df838fd Compare February 5, 2020 07:39
@princjef princjef merged commit 3187103 into master Feb 5, 2020
@princjef princjef deleted the repo-auth-fix branch February 5, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0