Update evaluator, prompt utils, default config, and eval service #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasinght
reviewed
Jun 7, 2025
| @@ -29,8 +29,13 @@ | |||
| # Disable remote eval plugins if the config is set | |||
| logger.info(f"setting remote eval plugins to {config.get('disable_remote_eval_plugins')}") | |||
| os.environ['PROMPTFOO_DISABLE_REDTEAM_REMOTE_GENERATION'] = str(config.get("disable_remote_eval_plugins")) | |||
| model = config.get("llm", {}).get("model") or "gpt-4" | |||
There was a problem hiding this comment.
pass None if not configured
|
|
||
| # Get model from config here | ||
| model = eval_config.get("llm", {}).get("model", "gpt-4") | ||
| suggested_categories = get_suggested_plugins(purpose, model=model) |
There was a problem hiding this comment.
it should be set only once through eval_init_config like email and plugin_file_path
| @@ -26,6 +26,10 @@ authz: | |||
| get_vector_db_details: 60 | |||
| get_vector_db_policies: 3 | |||
|
|
|||
| llm: | |||
There was a problem hiding this comment.
invalid change , remove this
also instead of llm: and model use one key "eval_llm_model"
| @@ -329,12 +329,13 @@ def validate_evaluate_request_params(paig_eval_id, generated_prompts, base_promp | |||
| return True, "" | |||
|
|
|||
|
|
|||
| def suggest_promptfoo_redteam_plugins_with_openai(purpose: str) -> Dict | str: | |||
| def suggest_promptfoo_redteam_plugins_with_openai(purpose: str, model: str = "gpt-4") -> Dict | str: | |||
There was a problem hiding this comment.
invalid change you should take in from library config like we are getting file path and email
| response['result'] = [] | ||
| try: | ||
| # Fetch model from eval_config or use default | ||
| model = eval_config.get("llm", {}).get("model", "gpt-4") |
There was a problem hiding this comment.
where is this eval_config defined , have you confused it with paig server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Describe your changes
Issue reference
This PR fixes issue #397
printed the log — it first tries to fetch the value from the config, and if it's not provided, it falls back to the default.
