8000 chore: enable perfsprint linter by mmorel-35 · Pull Request #717 · prometheus/common · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: enable perfsprint linter #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: enable perfsprint linter #717

merged 1 commit into from
Nov 7, 2024

Conversation

mmorel-35
Copy link
Contributor

Enables and fixes all rules of perfsprint linter

@mmorel-35
chore: enable perfsprint linter
3ea6508 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
SuperQ
SuperQ approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member
@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I thought there was another linter that complained about the fmt.Errorf() -> errors.New() change.

@SuperQ SuperQ merged commit 937c5b5 into prometheus:main Nov 7, 2024
7 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/perfsprint branch November 7, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @SuperQ
0