[BUGFIX] Protobuf scraping: reset exemplar position #14810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an error is thrown by the test, these numbers help you see which item is wrong. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This test fails. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
beorn7
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thank you very much.
As we know, the "line based" structure of the parsing code is a bad match for the protobuf parsing. It keeps haunting us, and we have to fix it eventually. (Also note the irony of the protobuf parsing code being in a directory called textparse…)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exemplarPosneeds to be reset to zero when we move on to the next histogram.Extend tests to have a case with two histograms.
Also fix commented test case numbers which were not monotonic.