8000 Include scrape pool name for dropped targets in /api/v1/targets by juliusv · Pull Request #16085 · prometheus/prometheus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Include scrape pool name for dropped targets in /api/v1/targets #16085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Include scrape pool name for dropped targets in /api/v1/targets #16085

merged 1 commit into from
Feb 27, 2025

Conversation

juliusv
Copy link
Member
@juliusv juliusv commented Feb 27, 2025

This is needed so we can display dropped targets in the right scrape pool in the web interface even if they have a non-default job name.

See also #16078

@juliusv juliusv requested a review from Nexucis February 27, 2025 09:14
@juliusv
Copy link
Member Author
juliusv commented Feb 27, 2025

Currently based on #16084, will change target branch to main here once that one is merged.

@juliusv juliusv force-pushed the dropped-target-scrapepool branch from 449bb30 to ba822e7 Compare February 27, 2025 09:22
@juliusv juliusv mentioned this pull request Feb 27, 2025
Closed
@juliusv juliusv force-pushed the dropped-target-scrapepool branch from ba822e7 to e32b18e Compare February 27, 2025 09:29
Base automatically changed from targets-api-cleanup to main February 27, 2025 14:08
@juliusv juliusv force-pushed the dropped-target-scrapepool branch from e32b18e to 9112a7b Compare February 27, 2025 14:09
@juliusv
Include scrape pool name for dropped targets in /api/v1/targets
4be2243 
This is needed so we can display dropped targets in the right scrape pool
in the web interface even if they have a non-default job name.

See also #16078

Fixes #16065

Signed-off-by: Julius Volz <julius.volz@gmail.com>
@juliusv juliusv force-pushed the dropped-target-scrapepool branch from 9112a7b to 4be2243 Compare February 27, 2025 14:17
@juliusv juliusv merged commit 77a505a into main Feb 27, 2025
45 checks passed
@juliusv juliusv deleted the dropped-target-scrapepool branch February 27, 2025 20:52
@charleskorn charleskorn mentioned this pull request Mar 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusv @Nexucis
0