docs(migration): clarify on content-type headers #16155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Juozas Janušaitis <lukas.janusaitis@hostinger.com>
c9de656 to
870b470
Compare
|
Thanks for this. There is #15830 to track that change, if you're interested. (By the way, specifying the media type is sufficient, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when creating a custom metric endpoint, we did not bother with setting the header, just making sure that the metric format met the standard. From the migration guide, it was unclear what format the content-type header is accepted in, and it is only visible in the source code. It would have helped me if I had found it sooner.