remote: Allow unwrapping of errors when reading from remote client #16437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
krajorama
reviewed
Apr 16, 2025
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
krajorama
approved these changes
Apr 16, 2025
bboreham
approved these changes
Apr 22, 2025
|
Thank you both! We use this to unwrap errors to summarise them in a downstream project, so if multiple targets fail with the same error we can have a more concise summary, e.g. an error that was like |
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
fmt.Errorfuses only %s and no %w, it can't be unwrapped, but when it does, it can be unwrapped to just the %w part.This change allows us to unwrap the error we get from here, so previously an error like
remote_read: remote server http://127.0.0.1:45687/api/v1/read returned http status 500 Internal Server Error: execution errorcouldn't be unwrapped, but now it can be unwrapped to justexecution error.