Target parameter labels should not be overridden by config params #11029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviHarrison
reviewed
Aug 6, 2022
I think we don't document this precedence anywhere explicitly, but SD labels can override other static settings from the scrape config so you're right that this is inconsistent. Strictly speaking it would be a breaking change now, although I hope nobody would rely on that. |
|
(During Prometheus bug scrub meeting) Sounds like @roidelapluie added this to Prometheus 3.0 release, we can do it then (should we add some release-3.0 branch or sth?) cc @roidelapluie |
a0245db to
379ead7
Compare
379ead7 to
fd1c49d
Compare
The following configuration snippet calls http://127.0.0.1:8000/?foo=value1 instead of http://127.0.0.1:8000/?foo=value2. This is incorrect, the labels of the target should be prefered. ```yaml - job_name: local params: foo: [value1] static_configs: - targets: ['127.0.0.1:8000'] labels: __param_foo: value2 ``` Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Julien <roidelapluie@o11y.eu>
fd1c49d to
bd91291
Compare
|
@bwplotka @machine424 @LeviHarrison @aknuds1 Ready for review and for Prom 3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following configuration snippet calls
http://127.0.0.1:8000/?foo=value1 instead of
http://127.0.0.1:8000/?foo=value2.
This is incorrect, the labels of the target should be prefered.
Signed-off-by: Julien Pivotto roidelapluie@o11y.eu