8000 Inherit views (V2) by jhollinger · Pull Request #511 · procore-oss/blueprinter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Inherit views (V2) #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: release-2.0
Choose a base branch
from
Open

Inherit views (V2) #511

wants to merge 5 commits into from

Conversation

jhollinger
Copy link
Contributor
@jhollinger jhollinger commented Mar 13, 2025 •
edited
Loading

Changes:

  • V2 blueprints inherit views from parents (like Legacy/V1)
  • view option to skip inheriting fields from the parent
  • Freeze a blueprint/view's extensions, options and fields after it's first eval'd
  • Disallow defining a :default view
  • If a view is redefined, append to the existing definition instead of replacing it (like Legacy/V1)

Legacy/V1's "identifier" view can be emulated like this:

class ApplicationBlueprint < Blueprinter::V2::Base
  field :id

  # this view will not inherit any fields
  view :identifier, empty: true do
    field :id
  end
end

@jhollinger jhollinger added the enhancement New feature or request label Mar 13, 2025
@jhollinger jhollinger requested review from ritikesh and a team as code owners March 13, 2025 17:58
@jhollinger jhollinger force-pushed the jh/2.0-inherit-views branch from 9dbfa69 to f01f713 Compare March 14, 2025 18:52
@jhollinger jhollinger force-pushed the jh/2.0-inherit-views branch from dd86213 to fb230a0 Compare April 1, 2025 15:31
@jhollinger jhollinger requested a review from lessthanjacob April 1, 2025 16:53
@jhollinger jhollinger force-pushed the jh/2.0-inherit-views branch 6 times, most recently from 080e83d to 02009df Compare April 5, 2025 15:46
@siba2893
Copy link
siba2893 commented Apr 9, 2025

This looks amazing! Waiting for this to get merged

@jhollinger
Don't allow redefining the default view
c949f62 
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
@jhollinger
Blueprints should inherit views from parents
0c4347a 
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
@jhollinger jhollinger force-pushed the jh/2.0-inherit-views branch from 02009df to a16d278 Compare April 29, 2025 19:21
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Jul 7, 2025
@jhollinger jhollinger reopened this Jul 8, 2025
@jhollinger
Copy link
Contributor Author

Take another at the fields options (maybe inherit_fields). Use existing setters to clear options & extensions.

@jhollinger jhollinger force-pushed the jh/2.0-inherit-views branch from 36871de to 14a18bb Compare July 9, 2025 16:18
@jhollinger
Allow views to opt out of inheriting fields
581770a 
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
@jhollinger jhollinger force-pushed the jh/2.0-inherit-views branch from 14a18bb to 4d368ae Compare July 9, 2025 16:19
jhollinger added 2 commits July 9, 2025 12:42
@jhollinger
Freeze extensions, options, and the schema when a blueprint is evaled
B853
fd86ad0 
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
@jhollinger
Append to duplicate views instead of replacing them
252443c 
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
@jhollinger jhollinger force-pushed the jh/2.0-inherit-views branch from 4d368ae to 252443c Compare July 9, 2025 16:43
@jhollinger
Copy link
Contributor Author

@lessthanjacob I've tentatively settled on an empty: true option to skip inheriting fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritikesh ritikesh Awaiting requested review from ritikesh ritikesh is a code owner

@lessthanjacob lessthanjacob Awaiting requested review from lessthanjacob

Assignees

@jhollinger jhollinger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhollinger @siba2893
0