8000 ch05 distributed image is incorrect? · Issue #357 · progit/progit2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ch05 distributed image is incorrect? #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
morefreeze opened this issue Aug 11, 2015 · 13 comments
Open

ch05 distributed image is incorrect? #357

morefreeze opened this issue Aug 11, 2015 · 13 comments

Comments

@morefreeze
Copy link

It appears in here. From context (start with line 120), we know Jessica works on both branch featureA and featureB, John works on featureA only, and Josie works on featureB (featureBee). So let's take a look at the image about workflow. John and Josie their name draw conversely in square box, is it right?

So I recommend whether we rename John as Alice who works on featureA, Josie as Bob who works on featureB(ee), Jessica as Candy who works on both. The origin naming is too confused.
@morefreeze morefreeze changed the title /book/05-distributed-git/images/managed-team-flow.png is incorrect? Could we rename the character's name that is confused? /book/05-distributed-git/images/managed-team-flow.png is incorrect? Could we rename the characters' name those is confused? Aug 11, 2015
@morefreeze morefreeze mentioned this issue Aug 11, 2015
Closed
@morefreeze morefreeze changed the title /book/05-distributed-git/images/managed-team-flow.png is incorrect? Could we rename the characters' name those is confused? ch05 distributed image is incorrect? Could we rename the characters' name those is confused? Aug 11, 2015
@morefreeze morefreeze changed the title ch05 distributed image is incorrect? Could we rename the characters' name those is confused? ch05 distributed image is incorrect? Aug 11, 2015
@jnavila
Copy link
Member
jnavila commented Oct 25, 2015

@ben Would you prefer changing the text or the picture (picture would make more sense)?

@ben
Copy link
Member
ben commented Oct 26, 2015

Yeah, changing the figure makes more sense, though I like the suggestion to change the names throughout. Can we use Carol instead of Candy, though?

@jnavila
Copy link
Member
jnavila commented Oct 27, 2015

Sorry, I don't understand your question. Where does Candy appear in this story?

@jnavila
Copy link
Member
jnavila commented Oct 27, 2015

Ah, OK, @ben. You meant changing the text as described by @morefreeze . Well, I don't have the editor application for the pictures, so this change can only go half-way.

@YueLinHo YueLinHo mentioned this issue Mar 15, 2016
Closed
@YueLinHo
Copy link
Contributor
YueLinHo commented Apr 6, 2016

So, using application Sketch on Mac to edit \diagram-source\progit.sketch file, then exporting png file.

  • Josie -> Alice (work on feature A)
  • John -> Bob (work on feature B)
  • Jessica -> Carol (work on feature A and B)

And modifying the file \book\05-distributed-git\sections\contributing.asc

  • John -> Alice (work on feature A)
  • Josie -> Bob (work on feature B)
  • Jessica -> Carol (work on feature A and B)

@YueLinHo
Copy link
Contributor

Why close it?

@morefreeze morefreeze reopened this Apr 20, 2016
@morefreeze
Copy link
Author

@YueLinHo Sorry, I thought you have edit the picture and merge PR. It's my mistake.

@YueLinHo
Copy link
Contributor

😄 I wish I could. I need a Mac and Sketch 3.

This was referenced Feb 12, 2019
Closed
Closed
Merged
@YueLinHo
Copy link
Contributor

@schacon said:

Jessica is my wife's name and John was her father's name.

cf. #1006 (comment)

@YueLinHo
Copy link
Contributor

Actually, I have created a new SVG file for this figure. And I can rename now. Here is the png exporting file from SVG file:
image

But, I have few questions:

  1. Is rename good? or just close this issue
  2. If we go renaming, I want to know the actual font face. (Consolas is used for now.)

@YueLinHo
Copy link
Contributor

Rename Candy to Carol (cf. ben's comment)
image

@morefreeze
Copy link
Author
morefreeze commented Feb 12, 2019 •
edited
Loading

I absolutely perfer new image but also respect Scott original naming.

  1. New naming is more clear for readers
  2. Scott is familiar with original naming without doubt

I'm appreciate your great work @YueLinHo

YueLinHo added a commit to YueLinHo/progit2 that referenced this issue Feb 12, 2019
@YueLinHo
Create managed-team-flow.svg and reanme John/Josie/Jessica to Alice/B…
d826f30 
…ob/Carol

Fixed issue progit#357

Figure: Basic sequence of this managed-team workflow, Private Managed Team, Chapter 5.
File: /book/05-distributed-git/sections/contributing.asc

Signed-off-by: Yue Lin Ho <yuelinho777@gmail.com>
@KZiemian
Copy link
KZiemian commented Sep 9, 2022 •
edited
Loading

The true stumbling block seems to be creating new graphics in the same graphics style as Mac's Sketch 3 (I don't know nothing about Macs so I maybe write stupid things). If @YueLinHo work can be utilized I will try (and probably fail) to make PR with appropriate changes. But, first I need to learn more AsciiDoc and this is can be a big stumbling block.

ryanc added a commit to ryanc/progit2 that referenced this issue Apr 3, 2025
@ryanc
Fix wrong names in managed-team-flow diagram
ea06320 
Josie and John were transposed

Fixes progit#1953
Refs progit#357, progit#694
@ryanc ryanc mentioned this issue Apr 3, 2025
Merged
2 tasks
ryanc added a commit to ryanc/progit2 that referenced this issue Apr 3, 2025
@ryanc
Fix wrong names in managed-team-flow diagram
62ceabb 
Josie and John were transposed

Fixes progit#1953
Fixes progit#694
Refs progit#357
ryanc added a commit to ryanc/progit2 that referenced this issue Apr 3, 2025
@ryanc
Fix wrong names in managed-team-flow diagram
1c46ca0 
Josie and John were transposed

Fixes progit#1953
Fixes progit#694
Refs progit#357
ryanc added a commit to ryanc/progit2 that referenced this issue Apr 3, 2025
@ryanc
Fix wrong names in managed-team-flow diagram
97e721e 
Josie and John were transposed

Fixes progit#1953
Fixes progit#694
Refs progit#357
ryanc added a commit to ryanc/progit2 that referenced this issue Apr 3, 2025
@ryanc
Fix wrong names in managed-team-flow diagram
c225939 
Josie and John were transposed

Fixes progit#1953
Fixes progit#694
Refs progit#357
ryanc added a commit to ryanc/progit2 that referenced this issue Apr 3, 2025
@ryanc
Fix wrong names in managed-team-flow diagram
b20dff6 
Josie and John were transposed

Fixes progit#1953
Fixes progit#694
Refs progit#357
ryanc added a commit to ryanc/progit2 that referenced this issue Apr 3, 2025
@ryanc
Fix wrong names in managed-team-flow diagram
47062ff 
Josie and John were transposed

Fixes progit#1953
Fixes progit#694
Refs progit#357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ben @jnavila @morefreeze @YueLinHo @KZiemian and others
0