Use monosace font for 'master' branch name #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back when I read the book, I had a feeling that some instances of "master branch" were supposed be adjectives, not precise name of the branch. Not sure if that was intended. |
ben
reviewed
Jan 7, 2020
There was a problem hiding this comment.
some instances of "master branch" were supposed be adjectives
It's possible that was our intent at the time, but I'm liking this PR more and more as I scan through it. We should be referring to literal names wherever possible, and choosing better adjectives than "master" in the other cases.
✨ on these changes, I just had one question for you.
|
🛳 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.