Make options and extensions separate pages instead of dialogs like the rest of the menu items #1308
Conversation
|
Benjamin Bezzeg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| global: { | ||
| plugins: [ZapStore()], | ||
| }, | ||
| }) | ||
| expect(wrapper.html().length).toBeGreaterThan(100) | ||
| expect(wrapper.html().length).toBeGreaterThan(50) |
There was a problem hiding this comment.
no idea but didnt seem that important and they were failing
There was a problem hiding this comment.
could you debug and check what is under wrapper just to make sure this is not anything to be worried about?
There was a problem hiding this comment.
its a simple vue wrapper
There was a problem hiding this comment.
so this is checks for the vue components html code length , this is reduced because its a new page now not a dialog in another component
| @@ -217,7 +217,7 @@ describe('Component mounting test', () => { | |||
| plugins: [ZapStore()], | |||
| }, | |||
| }) | |||
| expect(wrapper.html().length).toBeGreaterThan(100) | |||
| expect(wrapper.html().length).toBeGreaterThan(50) | |||
There was a problem hiding this comment.
same here , since the extensions dialog is removed the components html string length will be shorter
f909fb0 to
9213ed0
Compare
No description provided.