8000 GUI_fix by paulr34 · Pull Request #1313 · project-chip/zap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

GUI_fix #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2024
Merged

GUI_fix #1313

merged 3 commits into from
May 1, 2024

Conversation

paulr34
Copy link
Collaborator
@paulr34 paulr34 commented May 1, 2024

GUI fix

8000
@paulr34 paulr34 requested review from tecimovic and brdandu May 1, 2024 19:18
Copy link
Collaborator
@tecimovic tecimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes little sense.... You are deleting all non-dirty sessions upon startup.
How about the sessions that are CURRENTLY active, and the user is editing?

After the user clicks "Save" the session is no longer dirty. And the UI is still up.

But then a second instance of zap kicks in (because of generation) and simply wipes that session out?

You should NEVER delete an active session whether it's dirty or not.

Even so, I would never delete a session that is not more than a week or or something.

Remember: you can "restore" old sessions through that intermediate pre-session page....

@paulr34
Copy link
Collaborator Author
paulr34 commented May 1, 2024

This makes little sense.... You are deleting all non-dirty sessions upon startup. How about the sessions that are CURRENTLY active, and the user is editing?

After the user clicks "Save" the session is no longer dirty. And the UI is still up.

But then a second instance of zap kicks in (because of generation) and simply wipes that session out?

You should NEVER delete an active session whether it's dirty or not.

Even so, I would never delete a session that is not more than a week or or something.

Remember: you can "restore" old sessions through that intermediate pre-session page....

huh? how is a user editing a ZAP instance prior to startup?

@paulr34 paulr34 changed the title issue_1069 GUI_fix May 1, 2024
@paulr34 paulr34 merged commit 666004e into project-chip:master May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0