8000 Endpoint Composition - rootNode on Endpoint 0 (fullFamily) by paulr34 · Pull Request #1423 · project-chip/zap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Endpoint Composition - rootNode on Endpoint 0 (fullFamily) #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 24, 2024
Merged

Endpoint Composition - rootNode on Endpoint 0 (fullFamily) #1423

merged 5 commits into from
Sep 24, 2024

Conversation

paulr34
Copy link
Collaborator
@paulr34 paulr34 commented Sep 11, 2024 •
edited
Loading

Action to Fetch and Load Root Node Data
Description:
This PR introduces the loadComposition action to the Vuex store, which performs the following tasks:

Fetch Root Node Data: Retrieves root node data from the server.
Add Endpoint Type: Calls addEndpointType with the fetched data.
Add Endpoint: Calls addEndpoint with the data returned from addEndpointType

@codecov-commenter
Copy link
codecov-commenter commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.10526% with 22 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (80dfe7a) to head (83130fc).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/store/zap/actions.js 0.00% 8 Missing ⚠️
src-electron/db/query-endpoint.js 28.57% 5 Missing ⚠️
src-electron/rest/endpoint.js 44.44% 5 Missing ⚠️
src/components/ZclCreateModifyEndpoint.vue 0.00% 2 Missing ⚠️
src/App.vue 0.00% 1 Missing ⚠️
src/util/common-mixin.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
- Coverage   66.70%   66.68%   -0.03%     
==========================================
  Files         193      193              
  Lines       20853    20884      +31     
  Branches     4573     4579       +6     
==========================================
+ Hits        13911    13927      +16     
- Misses       6942     6957      +15
Flag Coverage Δ
66.68% <42.10%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ethanzhouyc
ethanzhouyc reviewed Sep 18, 2024
View reviewed changes
@paulr34 paulr34 requested a review from ethanzhouyc September 19, 2024 13:50
tecimovic
tecimovic reviewed Sep 20, 2024
View reviewed changes
@paulr34 paulr34 requested a review from tecimovic September 20, 2024 15:59
@paulr34 paulr34 force-pushed the rootNode branch 2 times, most recently from 4172763 to c36e1b8 Compare September 24, 2024 16:56
tecimovic
tecimovic reviewed Sep 24, 2024
View reviewed changes
@paulr34 paulr34 merged commit 83db0e6 into project-chip:master Sep 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecimovic tecimovic tecimovic approved these changes

@brdandu brdandu Awaiting requested review from brdandu brdandu is a code owner

@tbrkollar tbrkollar Awaiting requested review from tbrkollar

@dhchandw dhchandw Awaiting requested review from dhchandw

@ethanzhouyc ethanzhouyc Awaiting requested review from ethanzhouyc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulr34 @codecov-commenter @tecimovic @ethanzhouyc
0