Update iteration keyword replacement to have tokens to upper camel case
#1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing string casing works differently for names containing "." in them: matter has `Abc 1.2 Def` translated to `Abc12Def` where as existing string utils has it as `Abc1.2Def`. Changes: - move the token-based upperCamelCase into string utils - add unit tests - share the code between matter and util
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
paulr34
approved these changes
Apr 8, 2025
brdandu
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying latest zap after #1566 I found out that generation in matter differs from "general string utilites". Specifically for cluster "PM2.5 Concentration Measurement" the names I need are
Pm25ConcentrationMeasurement(to match class names so I can use{{asUpperCamelCase name}}in templates for consistency and compatiblity) where as string utilities gives mePm2.5ConcentrationMeasurement.This PR updates the naming for things and: