8000 show save button in ide when dirtyflag is sent to parent by paulr34 · Pull Request #1594 · project-chip/zap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ zap Public

show save button in ide when dirtyflag is sent to parent #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 22, 2025
Merged

show save button in ide when dirtyflag is sent to parent #1594

merged 14 commits into from
May 22, 2025

Conversation

paulr34
Copy link
Collaborator
@paulr34 paulr34 commented May 5, 2025

No description provided.

@paulr34 paulr34 requested review from tecimovic and brdandu as code owners May 5, 2025 13:35
@codecov-commenter
Copy link
codecov-commenter 8000 commented May 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.98%. Comparing base (dc0747a) to head (c2b7655).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
src/components/ZCLToolbar.vue 0.00% 1 Missing ⚠️
src/store/zap/mutations.js 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
+ Coverage   66.93%   66.98%   +0.05%     
==========================================
  Files         197      198       +1     
  Lines       21827    22228     +401     
  Branches     4817     4914      +97     
==========================================
+ Hits        14609    14890     +281     
- Misses       7218     7338     +120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ethanzhouyc ethanzhouyc self-requested a review May 6, 2025 15:47
@paulr34 paulr34 requested a review from dhchandw May 6, 2025 16:15
@paulr34 paulr34 force-pushed the fixSaveButton_IdeIntegration branch from c2b7655 to c475270 Compare May 7, 2025 15:09
@paulr34 paulr34 force-pushed the fixSaveButton_IdeIntegration branch from 6f18ef9 to 21f3dc6 Compare May 21, 2025 15:23
@paulr34 paulr34 merged commit f3e70da into project-chip:master May 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanzhouyc ethanzhouyc ethanzhouyc approved these changes

@brdandu brdandu brdandu approved these changes

@tecimovic tecimovic Awaiting requested review from tecimovic tecimovic is a code owner

@dhchandw dhchandw Awaiting requested review from dhchandw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulr34 @codecov-commenter @brdandu @ethanzhouyc
0