8000 [TC-CLCTRL-5.1] Add python test script new stop command based on test plan by uebati-siegenia · Pull Request #38401 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[TC-CLCTRL-5.1] Add python test script new stop command based on test plan #38401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

uebati-siegenia
Copy link
Contributor
@uebati-siegenia uebati-siegenia commented Apr 15, 2025

This PR adds python script for testing the Testcase TC-CLCTRL-5.1. This script should test the functionality of the Stop command with different MainStates.

Testing

@github-actions github-actions bot added the tests label Apr 15, 2025
Copy link

PR #38401: Size comparison from 0b33b64 to b9baaaf

Full report (1 build for stm32)
platform target config section 0b33b64c b9baaaf change % change
stm32 light STM32WB5MM-DK FLASH 461384 461384 0 0.0
RAM 141488 141488 0 0.0

@AliTalebVelux AliTalebVelux added App Clusters: Closures Window and Barrier (Door) Clusters v1.5 labels Apr 23, 2025
@AliTalebVelux AliTalebVelux changed the title Add new stop command python test case based on test plan [TC-CLCTRL-5.1] Add python test script new stop command based on test plan Apr 23, 2025
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@AliTalebVelux AliTalebVelux marked this pull request as ready for review April 24, 2025 07:46
@AliTalebVelux
Copy link
Contributor

This test script will be validated once the app is finished and added to the CI at the same time.

Copy link

PR #38401: Size comparison from f6c16f6 to fa6c21f

Full report (3 builds for cc32xx, stm32)
platform target config section f6c16f6 fa6c21f change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 543890 543890 0 0.0
RAM 205160 205160 0 0.0
lock CC3235SF_LAUNCHXL FLASH 577870 577870 0 0.0
RAM 205408 205408 0 0.0
stm32 light STM32WB5MM-DK FLASH 464432 464432 0 0.0
RAM 141504 141504 0 0.0

TestStep("2d", "TH waits for PIXIT.CLCTRL.StopDuration seconds"),
TestStep("2e", "TH reads from the DUT the MainState attribute"),
TestStep("3a", "TH sends command Calibrate to DUT"),
TestStep("3b", "after 2 seconds, TH reads from the DUT the MainState attribute"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TestStep("3b", "after 2 seconds, TH reads from the DUT the MainState attribute"),
TestStep("3b", "after 1 seconds, TH reads from the DUT the MainState attribute"),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pics = [
"CLCTRL.S",
"CLCTRL.S.C00.Rsp(Stop)"
"CLCTRL.S.F02(IS)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test plan indicates !CLCTRL.S.F02(IS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.step(1)
attributes = Clusters.ClosureControl.Attributes

feature_map = await self.read_boolcfg_attribute_expect_success(endpoint=endpoint, attribute=attributes.FeatureMap)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the correct function and these steps aren't in the test plan.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +123 to +126
if not is_ps_feature_supported:
logging.info("Position feature is not supported, skipping test case")
logging.info("Test step skipped")
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

PR #38401: Size comparison from f7f9f94 to 0704da2

Full report (3 builds for cc32xx, stm32)
platform target config section f7f9f94 0704da2 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 544226 544226 0 0.0
RAM 205160 205160 0 0.0
lock CC3235SF_LAUNCHXL FLASH 578190 578190 0 0.0
RAM 205408 205408 0 0.0
stm32 light STM32WB5MM-DK FLASH 464456 464456 0 0.0
RAM 141504 141504 0 0.0

Copy link

PR #38401: Size comparison from f7f9f94 to e1b2f45

Full report (3 builds for cc32xx, stm32)
platform target config section f7f9f94 e1b2f45 change % change
cc32xx air-purifier 67ED CC3235SF_LAUNCHXL FLASH 544226 544226 0 0.0
RAM 205160 205160 0 0.0
lock CC3235SF_LAUNCHXL FLASH 578190 578538 348 0.1
RAM 205408 205440 32 0.0
stm32 light STM32WB5MM-DK FLASH 464456 464456 0 0.0
RAM 141504 141504 0 0.0

@uebati-siegenia
Copy link
Contributor Author

This PR is added in the PR #39015.

@uebati-siegenia uebati-siegenia deleted the TC-CLCTRL-3.4 branch July 9, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0